[WIP] WINC-897: React to kubelet arg changes #2483
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wgahnagl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
controllers/configmap_controller.go
Outdated
| Watches(&core.Node{}, handler.EnqueueRequestsFromMapFunc(r.mapToServicesConfigMap), | ||
| builder.WithPredicates(nodeLabelChangedPredicate())). | ||
| Watches(&core.Node{}, handler.EnqueueRequestsFromMapFunc(r.mapToServicesConfigMap), | ||
| builder.WithPredicates(nodeconfigChangedPredicate())). |
There was a problem hiding this comment.
you can consolidate this into 1 by creating a smarter predicate func
There was a problem hiding this comment.
please explain why this watch is needed as well. Do we use node annotations to create (or modify) kubelet args? If so, please point to where we do that because i can't find where in our code
controllers/configmap_controller.go
Outdated
| node := &core.Node{} | ||
| if err := r.client.Get(ctx, kubeTypes.NamespacedName{ | ||
| Namespace: "", | ||
| Name: req.Name}, |
There was a problem hiding this comment.
which node would you get by doing this? I thought the req.Name would be the name of a configmap given the usage of handler.EnqueueRequestsFromMapFunc(r.mapToServicesConfigMap) in your added Watches
|
/retitle [WIP] WINC-897: React to kubelet arg changes |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@wgahnagl: This pull request references WINC-897 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No description provided.