Enable Go dependency updates in Renovate config #3308
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
renovate.json
Outdated
| "commitMessageTopic": "Go dependencies", | ||
| "matchManagers": ["gomod"], | ||
| "excludePackageNames": [ | ||
| "k8s.io/kubernetes" |
There was a problem hiding this comment.
need to also exclude OpenShift ones, they are handled in the submodule update script
renovate.json
Outdated
| "enabled": false, | ||
| "enabled": true, |
There was a problem hiding this comment.
Will this expand recursively to submodules?
There was a problem hiding this comment.
no it doesnt do recursive updates, it scans .gitmodules file in the root repository
- Updates submodule commit hashes when newer commits are available in upstream repos
- Only handles direct submodules - not submodules within submodules
There was a problem hiding this comment.
Neat! Do you think it can replace the manual hack/submodule update flow?
There was a problem hiding this comment.
yes it can but the issue we are going to run into is with the version bumps that need to go into the Makefile.
There was a problem hiding this comment.
fairly certain this was removed because it doesn't work in the way we want.
ignorePaths couldnt be used on specific submodules.
There was a problem hiding this comment.
I was remembering incorrectly
4b93f24
I'd like to see the documentation for this change.
Also this is not related to Enable Go dependency updates in Renovate config
renovate.json
Outdated
| "allowedPostUpgradeCommands": [ | ||
| "^rpm-lockfile-prototype rpms.in.yaml$", | ||
| "^go mod vendor$", | ||
| "^go mod tidy$" |
There was a problem hiding this comment.
consider adding go mod verify
mansikulkarni96
changed the title
mansikulkarni96
force-pushed
the
master
branch
2 times, most recently
from
de64e3b to
65d7c49
Compare
mansikulkarni96
changed the title
mansikulkarni96
force-pushed
the
master
branch
2 times, most recently
from
6b87563 to
62aec6d
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mansikulkarni96
force-pushed
the
master
branch
from
62aec6d to
efde8d4
Compare
|
LGTM, will defer the final stamp to @sebsoto |
renovate.json
Outdated
| "allowedCommands": [ | ||
| "^rpm-lockfile-prototype rpms.in.yaml$" | ||
| ], | ||
| "allowedPostUpgradeCommands": [ |
There was a problem hiding this comment.
https://docs.renovatebot.com/self-hosted-configuration/#allowedcommands
looks like this should be merged into allowedCommands
renovate.json
Outdated
| { | ||
| "groupName": "Go dependencies", | ||
| "commitMessageAction": "", | ||
| "commitMessageTopic": "Go dependencies", |
There was a problem hiding this comment.
https://docs.renovatebot.com/configuration-options/#commitmessagetopic
Looks like this might be for the individual dependency. Lets start with the default recommended value
renovate.json
Outdated
| "packageRules": [ | ||
| { | ||
| "groupName": "Go dependencies", | ||
| "commitMessageAction": "", |
There was a problem hiding this comment.
Looks like default is update. Don't think we need to change it.
https://docs.renovatebot.com/configuration-options/#commitmessagetopic
Add gomod manager and vendor directory handling to automatically update Go dependencies and their vendored files via Renovate PRs.
mansikulkarni96
force-pushed
the
master
branch
from
efde8d4 to
191accc
Compare
|
/lgtm |
|
@mansikulkarni96: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Add gomod manager and vendor directory handling to automatically update Go dependencies and their vendored files via Renovate PRs.