Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS v1.5.2+ updates (reduce types, C++, wtime) #28

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

davidozog
Copy link
Collaborator

This incorporates SOS changes from the following PRs:

After merging, we can close #26

@davidozog davidozog requested a review from wrrobin October 18, 2023 17:08
@davidozog davidozog changed the title Pr/sos v1.5.2+ updates SOS v1.5.2+ updates (reduce types, C++, wtime) Oct 18, 2023
@davidozog
Copy link
Collaborator Author

@kholland-intel - these changes will be helpful/necessary for Sandia-OpenSHMEM/SOS#1106

Copy link
Collaborator

@kholland-intel kholland-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bringing this PR back to my attention 👍

@davidozog
Copy link
Collaborator Author

Oops - I think we should bring the shmemx_team_node test here now, otherwise it could be lost in the submodule swap on PR Sandia-OpenSHMEM/SOS#1106.

@davidozog
Copy link
Collaborator Author

@kholland-intel - could you please do a sanity check review of 3154039?

@kholland-intel
Copy link
Collaborator

@kholland-intel - could you please do a sanity check review of 3154039?

diff looks good. 👍

@davidozog davidozog merged commit d52b3fb into openshmem-org:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants