Add member logo board #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladh
force-pushed
the
vladh/add-member-logo-board
branch
from
bb27d28
to
135c9f5
Compare
vladh
force-pushed
the
vladh/add-member-logo-board
branch
from
135c9f5
to
082250c
Compare
|
@chadwhitacre This is ready for review. |
Closed
|
Changed to embed SVGs. Seems like a better idea. |
|
Looking good!
What do you think of using the same algorithm we have now to show a selection of logos rather than all of them? That way we can give more companies exposure on the homepage as the effort grows. |
|
Yep, on it! Shall we merge this for now so things look nicer for the launch? |
|
Sure. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part of #126.
We had 21 logos, which divided into columns awkwardly, so one logo had to go. Sorry, Rector. :c
I think the one with 3 rows looks nice.
Screenshots
Actual mobile screenshot from my phone
All 5 rows
3 rows
2 rows
1 row