Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize filter selection condition #332

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Optimize filter selection condition #332

wants to merge 7 commits into from

Conversation

hamza-vd
Copy link
Contributor

@hamza-vd hamza-vd commented Feb 2, 2023 •
edited
Loading

This PR will

  • Make use of changes introduced in this immunization module's PR
  • Update the queries in RegisterQueryProvider to reference status column in VaccineOverdueCountRepository instead of search virtual table. This will eliminate issue mentioned here
  • Update Migration and count select query in VaccineOverdueCountRepositoryHelper
  • Update query in getFilterSelectionCondition to filter children fromVaccineOverdueCountRepository instead of search table

@hamza-vd hamza-vd requested a review from qiarie February 2, 2023 09:43
@hamza-vd hamza-vd mentioned this pull request Feb 21, 2023
Merged
@hamza-vd hamza-vd marked this pull request as ready for review February 23, 2023 06:18
@hamza-vd hamza-vd force-pushed the optimize-filter-selection-condition branch from 414010f to 38fb0a1 Compare February 23, 2023 07:34
@hamza-vd hamza-vd force-pushed the optimize-filter-selection-condition branch from 7be4633 to 0048979 Compare May 10, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiarie qiarie Awaiting requested review from qiarie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamza-vd