Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Change method and variable access modifiers #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: Change method and variable access modifiers #465

wants to merge 1 commit into from

Conversation

issyzac
Copy link
Member

@issyzac issyzac commented Nov 29, 2021

Changed access modifies for init method and some variable from private to protected

@issyzac issyzac requested review from allan-on and rkodev November 29, 2021 12:24
@allan-on
Copy link
Collaborator

allan-on commented Dec 6, 2021

@issyzac You'll need to add a test to address the drop in coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allan-on allan-on Awaiting requested review from allan-on

@rkodev rkodev Awaiting requested review from rkodev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyzac @allan-on