Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue283 #515

Merged
merged 74 commits into from
Sep 1, 2020
Merged

Issue283 #515

merged 74 commits into from
Sep 1, 2020

Conversation

ndegwamartin
Copy link
Contributor

@ndegwamartin ndegwamartin commented May 11, 2020

@ndegwamartin ndegwamartin force-pushed the issue283 branch 2 times, most recently from fb93c35 to 0336e70 Compare May 12, 2020 09:20
@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage increased (+0.03%) to 63.698% when pulling f5df6c4 on issue283 into b140a92 on master.

@ndegwamartin ndegwamartin requested a review from githengi May 26, 2020 06:51
@ndegwamartin ndegwamartin force-pushed the issue283 branch 2 times, most recently from 0685d79 to d4f2b61 Compare June 2, 2020 06:37
@ndegwamartin ndegwamartin force-pushed the issue283 branch 3 times, most recently from b3466e5 to 399f53a Compare June 8, 2020 19:40
@ndegwamartin ndegwamartin force-pushed the issue283 branch 2 times, most recently from 326ae5d to 00a38a3 Compare June 15, 2020 12:26
@ndegwamartin ndegwamartin force-pushed the issue283 branch 7 times, most recently from 844065f to 0a96175 Compare July 7, 2020 14:32
@ndegwamartin ndegwamartin force-pushed the issue283 branch 3 times, most recently from 0b2070e to 2b8d0f3 Compare July 20, 2020 15:50
@ndegwamartin ndegwamartin force-pushed the issue283 branch 2 times, most recently from f9506d7 to 7032990 Compare August 5, 2020 10:45
@githengi githengi requested a review from rkodev August 18, 2020 09:53
@ndegwamartin ndegwamartin force-pushed the issue283 branch 4 times, most recently from 69a534f to b306ed9 Compare August 25, 2020 15:42
- Error After Cancelling Log in by user from a Different Team
- Login fails for different team provider login on the first time
- Incorrect provider info shown on different team p authentication dialog
- Fix failing tests ✅
Comment on lines 115 to 117
/**
* @author Rodgers Andati
* @since 2019-04-25
* This method initializes httpurlconnection
* @param requestURLPath This is the url to be open http connection to.
* @param useBasicAuth This is whether to set up basic authentication or not.
* @return HttpURLConnection This returns the http connection to opensrp server.
*/
Copy link
Contributor

@githengi githengi Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the params documentation that were provided before

- Update java docs for HTTPAgent.initializeHttp
@ndegwamartin ndegwamartin merged commit ae8f7ba into master Sep 1, 2020
@ndegwamartin ndegwamartin deleted the issue283 branch September 1, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants