add logging for non successful dhis2 sync (#72)

* add logging for non successful dhis2 sync * update, log other responses as info
opensrp · Feb 1, 2022 · fd453fe · fd453fe
1 parent 0733261
commit fd453fe
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <artifactId>opensrp-server-connector</artifactId>
     <packaging>jar</packaging>
-    <version>2.3.5-SNAPSHOT</version>
+    <version>2.3.6-SNAPSHOT</version>
     <name>opensrp-server-connector</name>
     <description>OpenSRP Server Connector module</description>
     <url>http://github.com/OpenSRP/opensrp-server-connector</url>

diff --git a/src/main/java/org/opensrp/connector/dhis2/DHIS2DatasetPush.java b/src/main/java/org/opensrp/connector/dhis2/DHIS2DatasetPush.java
@@ -214,13 +214,21 @@ public void pushToDHIS2() {
 					}
 
 					JSONObject response = dhis2HttpUtils.post(DATAVALUESET_ENDPOINT, "", dhis2DatasetToPush.toString());
-					report.setStatus(response.getString("status"));
+					String status = response.optString("status");
+					if(DHIS2ResponseStatus.ERROR.name().equalsIgnoreCase(status)) {
+						logger.error(response);
+					} else if(DHIS2ResponseStatus.WARNING.name().equalsIgnoreCase(status)) {
+						logger.warn(response);
+					} else {
+						logger.info(response);
+					}
+					report.setStatus(status);
 					reportService.updateReport(report);
 					config.updateAppStateToken(DhisSchedulerConfig.dhis2_syncer_sync_report_by_date_updated,
 					    report.getServerVersion());
 				}
 				catch (JSONException e) {
-					logger.error("", e);
+					logger.error(e);
 				}
 
 			}

diff --git a/src/main/java/org/opensrp/connector/dhis2/DHIS2ResponseStatus.java b/src/main/java/org/opensrp/connector/dhis2/DHIS2ResponseStatus.java
@@ -0,0 +1,7 @@
+package org.opensrp.connector.dhis2;
+
+public enum DHIS2ResponseStatus {
+	SUCCESS,
+	WARNING,
+	ERROR
+}