Fix 'NoneType' object has no attribute 'get' #1191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are situations where the action object returned by libjuju may not
have the 'results' attribute which leads to using the default value when
running ".get('results')" which it's None.
This change sets the default value to an empty dictionary to allow the
following ".get('Stdout', '')" succeed.
|
This PR is being exercised by this gerrit change - https://review.opendev.org/c/openstack/charm-mysql-innodb-cluster/+/912487 |
sabaini
approved these changes
Mar 12, 2024
wolsen
requested changes
Mar 15, 2024
| @@ -238,7 +238,7 @@ async def _check_ca_present(model, ca_files): | |||
| for unit in units: | |||
| try: | |||
| output = await unit.run('cat {}'.format(ca_file)) | |||
| contents = output.data.get('results').get('Stdout', '') | |||
| contents = output.data.get('results', {}).get('Stdout', '') | |||
There was a problem hiding this comment.
Hmm, I think the problem here is that this is invoking direct juju invocations rather than the zaza model. The zaza model has logic to deal with the async result differences between libjuju 2.x and 3.x, but this code doesn't have that.
|
I'm closing this pull request as we used PR #1192 instead, which uses the underlying zaza.model changes to not use the unit.run directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where the action object returned by libjuju may not have the 'results' attribute which leads to using the default value when running ".get('results')" which it's None.
This change sets the default value to an empty dictionary to allow the following ".get('Stdout', '')" succeed.