Fix test for ceph-fs key rotation #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ceph-fs charm sometimes creates an entity called 'mds.None'. This is probably a bug, but in the meantime, we filter it out in the key rotation test class.
openstack-mirroring
pushed a commit
to openstack/charm-ceph-mon
that referenced
this pull request
May 15, 2024
This supports grafana dashboards and metrics scraping from the ceph mgr prometheus module. Have to build with charmcraft 2.6 for dependency handling Also remove zed tests as it's EOL Change-Id: I8b2f132a4997d205119f7afe2a1ab6b2ae4c0134 cherry-picked from e35d908 Change-Id: Idd479cef04a24ea64af643bd6e142ac40906e86c func-test-pr: openstack-charmers/zaza-openstack-tests#1208
|
lgtm as a tactical fix |
UtkarshBhatthere
pushed a commit
to UtkarshBhatthere/ceph-charms
that referenced
this pull request
Jan 30, 2025
This supports grafana dashboards and metrics scraping from the ceph mgr prometheus module. Have to build with charmcraft 2.6 for dependency handling Also remove zed tests as it's EOL Change-Id: I8b2f132a4997d205119f7afe2a1ab6b2ae4c0134 cherry-picked from 868adde Change-Id: Idd479cef04a24ea64af643bd6e142ac40906e86c func-test-pr: openstack-charmers/zaza-openstack-tests#1208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ceph-fs charm sometimes creates an entity called 'mds.None'. This is probably a bug, but in the meantime, we filter it out in the key rotation test class.