Added required config option idp_id to Keystone OpenIDC charm #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes z-o-t pass in the value of idp_id when configuring the Keystone OpenIDC charm during testing.
|
This PR is related to this change https://review.opendev.org/c/openstack/charm-keystone-openidc/+/922049. |
openstack-mirroring
pushed a commit
to openstack/charm-keystone-openidc
that referenced
this pull request
Jul 2, 2024
The values of the protocol ID and identity provider ID are reversed in the charm's code. This causes the mod_auth_openidc config to render incorrectly in the Apache template. This change fixes the reversed values and adds a config option for defining the identity provider ID. This change also adds new config options for enabling using mod_auth_openidc with multiple Keystone units and with proxies. Closes-Bug: #2065590 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1235 Change-Id: Ie7da5f9a85027a287aad9958c54848a948f8495c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes z-o-t pass in the value of idp_id when configuring the Keystone OpenIDC charm during testing.
The idp_id cannot be set to a default value. It has to match the name of the identity provider you set up in Keystone for federation. If you do not do this, the URLs in the template do not render properly.