Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set enable-chassis-as-gateway controlplane as false in uni07eta #419

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fyanac
Copy link
Contributor

@fyanac fyanac commented Oct 16, 2024

uni07eta has networkers that are used as a gateway.

Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fyanac
Once this PR has been reviewed and has the lgtm label, please assign raukadah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 16, 2024

Hi @fyanac. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bharathmv13
Copy link

Please test this and paste results. thanks!

uni07eta has networkers that are used as a gateway.
@eduolivares
Copy link
Contributor

Something I have been talking with @fyanac:
I know octavia folks are working to enable octavia and add octavia tests to some downstream uni jobs.
In order to work properly, octavia amphora provider needs OCP nodes acting as gateway chassis.
So, with this PR, octavia amphora provider could not be used in both alpha and eta jobs.

Hence, please check with octavia folks what we should do before merging this patch (maybe we can apply it only to one of the jobs, IDK...).

Ccing @lavraham @beagles @gthiemonge

@fyanac fyanac changed the title Set enable-chassis-as-gateway controlplane as false in alpha and eta Set enable-chassis-as-gateway controlplane as false in uni07eta Oct 16, 2024
@fyanac
Copy link
Contributor Author

fyanac commented Oct 16, 2024

Something I have been talking with @fyanac: I know octavia folks are working to enable octavia and add octavia tests to some downstream uni jobs. In order to work properly, octavia amphora provider needs OCP nodes acting as gateway chassis. So, with this PR, octavia amphora provider could not be used in both alpha and eta jobs.

Hence, please check with octavia folks what we should do before merging this patch (maybe we can apply it only to one of the jobs, IDK...).

Ccing @lavraham @beagles @gthiemonge

I modified the patch just to change it into uni07eta job.

@eduolivares
Copy link
Contributor

you need to add a section here:
https://github.com/fyanac/architecture/blob/change_gw/dt/uni07eta/kustomization.yaml#L322-L332
for data.ovn.ovnController.external-ids so that kustomize applied your new values to the output CR.

It will be similar to this:
https://github.com/fyanac/architecture/blob/change_gw/examples/dt/bgp/bgp_dt01/control-plane/kustomization.yaml#L147-L158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants