Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BGP] Add AZs to schedule Octavia mgmt network on OCP nodes #425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BGP] Add AZs to schedule Octavia mgmt network on OCP nodes #425

wants to merge 2 commits into from

Conversation

eduolivares
Copy link
Contributor

@eduolivares eduolivares commented Oct 25, 2024 •
edited by openshift-ci bot
Loading

Octavia needs to schedule its management network on the OCP nodes/workers.
With BGP, OCP nodes/workers should not be used to schedule OVN router ports.
In order to resolve this conflict, this patch uses Availability Zones.

OSPRH-10768

@openshift-ci openshift-ci bot requested review from abays and cjeanner October 25, 2024 11:16
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eduolivares
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/94fc52759310468c907c97abc9319295

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-bgp_dt01 FAILURE in 3m 19s

@eduolivares eduolivares force-pushed the bgp-octavia-amphora-az branch 2 times, most recently from a518603 to 266b0e1 Compare October 25, 2024 11:25
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9ef95563c874455ca00e249d417512fa

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-bgp FAILURE in 3m 19s
✔️ rhoso-architecture-validate-bgp_dt01 SUCCESS in 4m 46s

@eduolivares eduolivares force-pushed the bgp-octavia-amphora-az branch from 266b0e1 to a0d458e Compare October 25, 2024 11:31
@eduolivares eduolivares added the do-not-merge Changes are not ready to be merged label Oct 25, 2024
@eduolivares eduolivares force-pushed the bgp-octavia-amphora-az branch 2 times, most recently from 8ab2791 to f27943e Compare October 28, 2024 14:34
@abays abays requested a review from karelyatin October 28, 2024 14:35
@eduolivares eduolivares force-pushed the bgp-octavia-amphora-az branch 3 times, most recently from 52715f7 to 8fd216a Compare October 31, 2024 08:10
@karelyatin
Copy link
Contributor

/lgtm, is this tested already?

@eduolivares
Copy link
Contributor Author

/lgtm, is this tested already?

@karelyatin, it's not ready yet. Notice the do-not-merge label.
I will ping you when it is ready. Thanks!

@eduolivares eduolivares force-pushed the bgp-octavia-amphora-az branch 3 times, most recently from 12ef783 to 9a7ad77 Compare November 5, 2024 13:00
@eduolivares
[BGP] Add AZs to schedule Octavia mgmt network on OCP nodes
8e78650 
Octavia needs to schedule its management network on the OCP
nodes/workers.
With BGP, OCP nodes/workers should not be used to schedule OVN router
ports.
In order to resolve this conflict, this patch uses Availability Zones.

OSPRH-10768
@eduolivares eduolivares force-pushed the bgp-octavia-amphora-az branch 2 times, most recently from b9b3b53 to 4c1ad69 Compare November 7, 2024 09:42
@eduolivares eduolivares added do-not-merge/work-in-progress and removed do-not-merge Changes are not ready to be merged labels Nov 11, 2024
@eduolivares
[UniAlpha][Octavia] Enable createDefaultLbMgmtNetwork and manageLbMgm…
950481b 
…tNetworks

When octavia is configured with AZs, parameters
createDefaultLbMgmtNetwork and manageLbMgmtNetworks are set to False by
default. With this change, they are set to True on the unialpha config.
@eduolivares eduolivares force-pushed the bgp-octavia-amphora-az branch from 4c1ad69 to 950481b Compare November 12, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthiemonge gthiemonge gthiemonge left review comments

@abays abays Awaiting requested review from abays

@cjeanner cjeanner Awaiting requested review from cjeanner

@karelyatin karelyatin Awaiting requested review from karelyatin

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduolivares @karelyatin @gthiemonge