-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests for HSM Support #190
Functional tests for HSM Support #190
Conversation
6d5561c
to
19dd70c
Compare
19dd70c
to
dca4e9b
Compare
9cb2c87
to
8c4c86f
Compare
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start generally. Just a few suggestions of things to add.
recheck |
981c02e
to
e600c2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes you have made look pretty good. There are a bunch of unrelated changes though. Please rebase first.
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
e600c2d
to
c72ae2e
Compare
Signed-off-by: Mauricio Harley <[email protected]>
c72ae2e
to
09d7f3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauricioharley, vakwetu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1482a31
into
openstack-k8s-operators:main
Functional tests for the Luna HSM model support.