Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests for HSM Support #190

Conversation

mauricioharley
Copy link
Contributor

Functional tests for the Luna HSM model support.

@xek xek force-pushed the luna_functional_tests branch from 6d5561c to 19dd70c Compare December 3, 2024 08:30
@xek xek marked this pull request as draft December 3, 2024 08:31
gibizer
gibizer previously requested changes Dec 3, 2024
hack/crd-schema-checker.sh Outdated Show resolved Hide resolved
api/v1beta1/common_types.go Outdated Show resolved Hide resolved
@mauricioharley mauricioharley marked this pull request as ready for review December 3, 2024 17:09
@openshift-ci openshift-ci bot requested review from d34dh0r53 and dprince December 3, 2024 17:10
@gibizer gibizer dismissed their stale review December 9, 2024 15:56

My comments were addressed

@mauricioharley mauricioharley force-pushed the luna_functional_tests branch 2 times, most recently from 9cb2c87 to 8c4c86f Compare December 16, 2024 16:51
@mauricioharley
Copy link
Contributor Author

/retest

1 similar comment
@mauricioharley
Copy link
Contributor Author

/retest

Copy link
Contributor

@vakwetu vakwetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start generally. Just a few suggestions of things to add.

@vakwetu
Copy link
Contributor

vakwetu commented Dec 20, 2024

recheck

Copy link
Contributor

@vakwetu vakwetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes you have made look pretty good. There are a bunch of unrelated changes though. Please rebase first.

Mauricio Harley and others added 5 commits January 6, 2025 10:51
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Signed-off-by: Mauricio Harley <[email protected]>
Copy link
Contributor

@vakwetu vakwetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauricioharley, vakwetu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mauricioharley,vakwetu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1482a31 into openstack-k8s-operators:main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants