Add override for barbican operator #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker does not talk to keystone so we can remove all the commented out code for this.
vakwetu
requested review from
stuggi,
xek,
d34dh0r53,
dmendiza,
abays,
mauricioharley and
afaranha
|
This looks like its working correctly (at least locally). I managed to test with kubefwd setting up the relevant paths for me. |
|
the change looks good to me |
dmendiza
changed the title
|
acked by @dmendiza , going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested as of yet. But this moves the creation of the route to the openstack operator so that we can take advantage of TLS-E enablement there. This is a prereq for a patch to add the barbican operator to the openstack-operator