Make Secure RBAC configurable #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakwetu
reviewed
Dec 13, 2023
controllers/barbican_controller.go
Outdated
| "ServiceURL": "TODO", | ||
| "TransportURL": string(transportURLSecret.Data["transport_url"]), | ||
| "LogFile": fmt.Sprintf("%s%s.log", barbican.BarbicanLogPath, instance.Name), | ||
| "enableSecureRBAC": instance.Spec.BarbicanAPI.EnableSecureRBAC, |
There was a problem hiding this comment.
nit: We should be consistent here and use "EnableSecureRBAC" instead of "enableSecureRBAC"
vakwetu
reviewed
Dec 13, 2023
| "ServiceURL": "https://barbican.openstack.svc:9311", | ||
| "TransportURL": string(transportURLSecret.Data["transport_url"]), | ||
| "LogFile": fmt.Sprintf("%s%s.log", barbican.BarbicanLogPath, instance.Name), | ||
| "enableSecureRBAC": instance.Spec.EnableSecureRBAC, |
vakwetu
reviewed
Dec 13, 2023
vakwetu
requested changes
Dec 13, 2023
This patch adds a new field to the BarbicanAPI spec to configure "Consistent and Secure RBAC" [1]. The API configuration template was modified to use the value in this field instead of being hard-coded to always be on. Jira: OSPRH-2129 [1] https://governance.openstack.org/tc/goals/selected/consistent-and-secure-rbac.html
dmendiza
force-pushed
the
secure-rbac
branch
from
40dcaf1 to
cda44d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new field to the BarbicanAPI spec to configure "Consistent and Secure RBAC" [1]. The API configuration template was modified to use the value in this field instead of being hard-coded to always be on.
Jira: OSPRH-2129
[1] https://governance.openstack.org/tc/goals/selected/consistent-and-secure-rbac.html