Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creation of clouds.yaml file to edpm_prepare #1057

Conversation

eduolivares
Copy link
Contributor

@eduolivares eduolivares commented Jan 24, 2024

The clouds.yaml file was created by the tempest role because it is needed to execute tempest tests.
Later, those tasks from the tempest role were reused by the tobiko role, because the file is needed for running tobiko as well. This change moves the creation of clouds.yaml to an earlier step in the edpm_prepare role and it could be reused by any other stages executed later (e.g. new test frameworks).

Depends-On: openstack-k8s-operators/tcib#123
OSPRH-1670

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

The clouds.yaml file was created by the tempest role because it is
needed to execute tempest tests.
Later, those tasks from the tempest role were reused by the tobiko role,
because the file is needed for running tobiko as well.
This change moves the creation of clouds.yaml to an earlier step in the
edpm_prepare role and it could be reused by any other stages executed
later (e.g. new test frameworks).
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f9275d3da5034e5296510a6eef3c01df

✔️ openstack-k8s-operators-content-provider SUCCESS in 42m 25s
podified-multinode-edpm-deployment-crc FAILURE in 21m 47s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 26m 13s
✔️ noop SUCCESS in 0s
✔️ cifmw-molecule-edpm_prepare SUCCESS in 5m 02s
✔️ cifmw-molecule-tempest SUCCESS in 5m 09s
✔️ cifmw-molecule-tobiko SUCCESS in 5m 11s

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjeanner
Copy link
Contributor

cjeanner commented Apr 4, 2024

@eduolivares heya! Is this still something you're working on? Do you need any help to finalize this change?

@eduolivares
Copy link
Contributor Author

@eduolivares heya! Is this still something you're working on? Do you need any help to finalize this change?

@cjeanner I postponed this PR for too long and now I'd need to update it (for example, the tobiko role doesn't exist anymore) and this is not a good moment for me to resume working on it.
Perhaps I should close it and take it again when I have more time.

@cjeanner
Copy link
Contributor

@eduolivares care to close it, probably get some jira card to not forget about that task, and re-open a PR when you can handle it? That would help cleaning the backlog in here, really.

Thanks!

@eduolivares eduolivares deleted the create-clouds-yaml-once branch July 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants