-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move creation of clouds.yaml file to edpm_prepare #1057
Move creation of clouds.yaml file to edpm_prepare #1057
Conversation
The clouds.yaml file was created by the tempest role because it is needed to execute tempest tests. Later, those tasks from the tempest role were reused by the tobiko role, because the file is needed for running tobiko as well. This change moves the creation of clouds.yaml to an earlier step in the edpm_prepare role and it could be reused by any other stages executed later (e.g. new test frameworks).
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f9275d3da5034e5296510a6eef3c01df ✔️ openstack-k8s-operators-content-provider SUCCESS in 42m 25s |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@eduolivares heya! Is this still something you're working on? Do you need any help to finalize this change? |
@cjeanner I postponed this PR for too long and now I'd need to update it (for example, the tobiko role doesn't exist anymore) and this is not a good moment for me to resume working on it. |
@eduolivares care to close it, probably get some jira card to not forget about that task, and re-open a PR when you can handle it? That would help cleaning the backlog in here, really. Thanks! |
The clouds.yaml file was created by the tempest role because it is needed to execute tempest tests.
Later, those tasks from the tempest role were reused by the tobiko role, because the file is needed for running tobiko as well. This change moves the creation of clouds.yaml to an earlier step in the edpm_prepare role and it could be reused by any other stages executed later (e.g. new test frameworks).
Depends-On: openstack-k8s-operators/tcib#123
OSPRH-1670
As a pull request owner and reviewers, I checked that: