-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added VA HCI trigger experimental job #2252
Conversation
Skipping CI for Draft Pull Request. |
/trigger github-experimental |
Experimental Build Failed (github-experimental pipeline). https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/411f78dfb9a84357836032e1f6ebb224 ❌ downstream-va-hci-trigger-job FAILURE in 1m 12s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dae626532dd4456eb93dae4027c377a6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 27s |
/trigger github-experimental |
From this trigger comment , Following buildset got generated . From trigger job log: Following trigger review got created.
It generates a trigger file which runs downstream VA HCI job. |
/trigger github-experimental |
1 similar comment
/trigger github-experimental |
After merging this config change and retriggering the same via this comment. By checking the trigger job, We have review with origin pr link.
|
/trigger github-experimental |
After merging Add depends-on in the trigger review commit message config change and triggering the experimental job again . Here is the buildset url. From the job log, Below review got triggered.
Here is the commit message: https://review.rdoproject.org/r/c/tripleo-downstream-trigger-nested-virt/+/54154/4//COMMIT_MSG |
256908a
to
10c4ef8
Compare
zuul.d/trigger_jobs.yaml
Outdated
- .spellcheck.yml | ||
- roles/dlrn_report | ||
- roles/dlrn_promote | ||
- roles/devscripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to trigger va-hci when devscripts
, dnsmasq
, reproducer
and virtualbmc
roles are affected: they are all used to get the infra layer, OCP and some services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as for nat64_appliance, it might be requested if we get va-hci with IPv6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libvirt_manager
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, didn't see you listed the "files" + "irrelevant-files" - iirc this doesn't work like that afaik, because you list the same path in both blocks.
And there are far more roles to track down, lemme list the ones that should trigger.
10c4ef8
to
19f61b9
Compare
/lgtm |
19f61b9
to
fb56fe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
We can refine if needed later.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It is based on the work done by @son-vyas openstack-k8s-operators/ci-playground#12. It will help users to trigger VA HCI job by "trigger github-experimental". Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
fb56fe0
to
4eae44b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick 18.0.0-proposed |
@raukadah: new pull request created: #2352 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
It is based on the work done by @son-vyas openstack-k8s-operators/ci-playground#12.
It will help users to trigger VA HCI job by "trigger github-experimental".
Testresults: