Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VA HCI trigger experimental job #2252

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Aug 22, 2024

It is based on the work done by @son-vyas openstack-k8s-operators/ci-playground#12.

It will help users to trigger VA HCI job by "trigger github-experimental".

Testresults:

  1. VA job triggered
  2. Proper changes in the trigger job

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@raukadah
Copy link
Contributor Author

/trigger github-experimental

Copy link

Experimental Build Failed (github-experimental pipeline).

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/411f78dfb9a84357836032e1f6ebb224

downstream-va-hci-trigger-job FAILURE in 1m 12s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dae626532dd4456eb93dae4027c377a6

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 27s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 16m 28s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 12s
cifmw-pod-pre-commit FAILURE in 7m 08s
cifmw-pod-zuul-files FAILURE in 4m 16s

@raukadah
Copy link
Contributor Author

/trigger github-experimental

@raukadah
Copy link
Contributor Author

raukadah commented Aug 22, 2024

From this trigger comment , Following buildset got generated .

From trigger job log: Following trigger review got created.

2024-08-22 03:04:02.832557 | TASK [Submit the Gerrit review]
2024-08-21 23:04:04.350009 | primary | remote:
2024-08-21 23:04:04.380440 | primary | remote: Processing changes: refs: 1, new: 1
2024-08-21 23:04:04.380593 | primary | remote: Processing changes: refs: 1, new: 1
2024-08-21 23:04:04.380612 | primary | remote: Processing changes: refs: 1, new: 1
2024-08-21 23:04:04.380661 | primary | remote: Processing changes: refs: 1, new: 1, done
2024-08-21 23:04:04.380676 | primary | remote:
2024-08-21 23:04:04.380690 | primary | remote: SUCCESS
2024-08-21 23:04:04.380704 | primary | remote:
2024-08-21 23:04:04.380719 | primary | remote:   https://review.rdoproject.org/r/c/tripleo-downstream-trigger-nested-virt/+/54154 Triggering VA HCI job [NEW]
2024-08-21 23:04:04.380733 | primary | remote:
2024-08-21 23:04:04.380750 | primary | To ssh://review.rdoproject.org:29418/tripleo-downstream-trigger-nested-virt
2024-08-21 23:04:04.380768 | primary |  * [new reference]   HEAD -> refs/for/master
2024-08-22 03:04:04.882271 | primary | changed

It generates a trigger file which runs downstream VA HCI job.

@raukadah
Copy link
Contributor Author

/trigger github-experimental

1 similar comment
@raukadah
Copy link
Contributor Author

/trigger github-experimental

@raukadah
Copy link
Contributor Author

After merging this config change and retriggering the same via this comment.
Following buildset url got generated.

By checking the trigger job, We have review with origin pr link.

2024-08-22 07:53:55.992404 | TASK [Submit the Gerrit review]
2024-08-22 03:53:57.881700 | primary | remote:
2024-08-22 03:53:57.895406 | primary | remote: Processing changes: refs: 1, updated: 1
2024-08-22 03:53:57.895483 | primary | remote: Processing changes: refs: 1, updated: 1
2024-08-22 03:53:57.895505 | primary | remote: Processing changes: refs: 1, updated: 1
2024-08-22 03:53:57.895614 | primary | remote: Processing changes: refs: 1, updated: 1, done
2024-08-22 03:53:57.895638 | primary | remote: commit be09f28: warning: subject >50 characters; use shorter first paragraph
2024-08-22 03:53:57.895654 | primary | remote: commit be09f28: warning: too many message lines longer than 72 characters; manually wrap lines
2024-08-22 03:53:57.895668 | primary | remote: warning: be09f28: no files changed, message updated
2024-08-22 03:53:57.895682 | primary | remote:
2024-08-22 03:53:57.895696 | primary | remote: SUCCESS
2024-08-22 03:53:57.895710 | primary | remote:
2024-08-22 03:53:57.895724 | primary | remote:   https://review.rdoproject.org/r/c/tripleo-downstream-trigger-nested-virt/+/54154 Triggering VA HCI job by https://github.com/openstack-k8s-operators/ci-framew...
2024-08-22 03:53:57.895745 | primary | remote:
2024-08-22 03:53:57.895758 | primary | remote: The following approvals got outdated and were removed:
2024-08-22 03:53:57.895772 | primary | remote: * Verified+1 by zull-sf-hosted CI
2024-08-22 03:53:57.895789 | primary | remote:
2024-08-22 03:53:57.895803 | primary | remote:
2024-08-22 03:53:57.895817 | primary | To ssh://review.rdoproject.org:29418/tripleo-downstream-trigger-nested-virt
2024-08-22 03:53:57.895830 | primary |  * [new reference]   HEAD -> refs/for/master
2024-08-22 07:53:58.049269 | primary | changed

@raukadah
Copy link
Contributor Author

/trigger github-experimental

@raukadah
Copy link
Contributor Author

After merging Add depends-on in the trigger review commit message config change and triggering the experimental job again .

Here is the buildset url.

From the job log, Below review got triggered.

2024-08-22 08:10:25.384890 | TASK [Submit the Gerrit review]
2024-08-22 04:10:26.875884 | primary | remote:
2024-08-22 04:10:26.891406 | primary | remote: Processing changes: refs: 1, updated: 1
2024-08-22 04:10:26.891435 | primary | remote: Processing changes: refs: 1, updated: 1
2024-08-22 04:10:26.891442 | primary | remote: Processing changes: refs: 1, updated: 1
2024-08-22 04:10:26.891449 | primary | remote: Processing changes: refs: 1, updated: 1, done
2024-08-22 04:10:26.891455 | primary | remote: commit 0226f0f: warning: subject >50 characters; use shorter first paragraph
2024-08-22 04:10:26.891462 | primary | remote: commit 0226f0f: warning: too many message lines longer than 72 characters; manually wrap lines
2024-08-22 04:10:26.891469 | primary | remote: warning: 0226f0f: no files changed, message updated
2024-08-22 04:10:26.891476 | primary | remote:
2024-08-22 04:10:26.891482 | primary | remote: SUCCESS
2024-08-22 04:10:26.891488 | primary | remote:
2024-08-22 04:10:26.891500 | primary | remote:   https://review.rdoproject.org/r/c/tripleo-downstream-trigger-nested-virt/+/54154 Triggering VA HCI job by https://github.com/openstack-k8s-operators/ci-framew...
2024-08-22 04:10:26.891509 | primary | remote:
2024-08-22 04:10:26.891516 | primary | To ssh://review.rdoproject.org:29418/tripleo-downstream-trigger-nested-virt
2024-08-22 04:10:26.891523 | primary |  * [new reference]   HEAD -> refs/for/master
2024-08-22 08:10:26.945980 | primary | changed

Here is the commit message: https://review.rdoproject.org/r/c/tripleo-downstream-trigger-nested-virt/+/54154/4//COMMIT_MSG
image

@raukadah raukadah marked this pull request as ready for review August 22, 2024 08:53
@raukadah raukadah changed the title [DNM] Checking downstream VA HCI trigger job flow Added VA HCI trigger experimental job Aug 22, 2024
- .spellcheck.yml
- roles/dlrn_report
- roles/dlrn_promote
- roles/devscripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to trigger va-hci when devscripts, dnsmasq, reproducerand virtualbmc roles are affected: they are all used to get the infra layer, OCP and some services.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as for nat64_appliance, it might be requested if we get va-hci with IPv6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libvirt_manager?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, didn't see you listed the "files" + "irrelevant-files" - iirc this doesn't work like that afaik, because you list the same path in both blocks.

And there are far more roles to track down, lemme list the ones that should trigger.

@son-vyas
Copy link
Contributor

/lgtm

Copy link
Contributor

@cjeanner cjeanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

We can refine if needed later.

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

It is based on the work done by @son-vyas
openstack-k8s-operators/ci-playground#12.

It will help users to trigger VA HCI job by "trigger github-experimental".

Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ef0f9a2 into main Aug 22, 2024
4 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the trigger_check branch August 22, 2024 14:26
@raukadah
Copy link
Contributor Author

/cherrypick 18.0.0-proposed

@openshift-cherrypick-robot

@raukadah: new pull request created: #2352

In response to this:

/cherrypick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants