Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Tobiko tests to be performed last. #2339

Merged

Conversation

gmarcian
Copy link

Since Tobico may include disruptive tests (faults), it is better to execute it at the end, after the non-disruptive tests (like Tempest, Horizon, etc).

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

Hi @gmarcian. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot marked this pull request as draft September 11, 2024 12:07
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@eduolivares
Copy link
Contributor

/ok-to-test

@raukadah
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eduolivares
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f019921 into openstack-k8s-operators:main Sep 13, 2024
4 checks passed
@eduolivares
Copy link
Contributor

/cherrypick 18.0.0-proposed

@openshift-cherrypick-robot

@eduolivares: new pull request created: #2353

In response to this:

/cherrypick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants