Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0-fr1] Add missing node groups for multicell nodeset #2507

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2485

/assign viroel

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from viroel. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft October 31, 2024 19:58
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@lewisdenny
Copy link
Collaborator

@viroel I think you created this to work around the D/S Zuul error that was fixed by not importing this branch in D/S Zuul?

@bogdando I see the linked Jira is targeting FR2, does this need to be back ported to FR1 branch?

@bogdando
Copy link
Contributor

bogdando commented Nov 4, 2024

@lewisdenny no need to backport, ther ain't gonna be multicell in FR1

albeit, merging it won't hurt - just a noop

@lewisdenny lewisdenny closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants