Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-operator] Move away from Jobs to Pods #2604

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

lpiwowar
Copy link
Contributor

With this PR [1] the test operator dropped the usage of OCP Jobs for
spawning of the test pods.

This change updates the test-operator role so that it works with the
new version of the test-operator that spawns test pods directly through
the OCP Pods object.

[1] openstack-k8s-operators/test-operator#266

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Dec 13, 2024
The test-operator is using Jobs to spawn test pods even though it does
not use any features of this k8s object. Plus usage of the Jobs requires
creation of ServiceAccount in the target namespaces. In order to be able
to create a new, SA the test-oprator has to have a rights to create new
roles and rolebindings which in our case makes the attack surface
larger.

This patch drops the usage of Jobs and moves to Pods.

Depends-On: openstack-k8s-operators/ci-framework#2604
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f7a064a541ce4ca396fd07d4a987c964

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 35s
podified-multinode-edpm-deployment-crc FAILURE in 1h 05m 54s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 37m 09s
cifmw-multinode-tempest FAILURE in 1h 07m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 37s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 22s
✔️ build-push-container-cifmw-client SUCCESS in 21m 26s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 13s

With this PR [1] the test operator dropped the usage of OCP Jobs for
spawning of the test pods.

This change updates the test-operator role so that it works with the
new version of the test-operator that spawns test pods directly through
the OCP Pods object.

[1] openstack-k8s-operators/test-operator#266
@lpiwowar
Copy link
Contributor Author

lpiwowar commented Dec 17, 2024

/hold

These PRs need to be merged at the same time. The idea is to first get /approved and /lgtm for both of them and then we can remove /hold at the same time:

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/59ad346a9c9648ffa3aeedd5d6ce94af

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 31s
cifmw-crc-podified-edpm-baremetal FAILURE in 48m 26s
✔️ cifmw-multinode-tempest SUCCESS in 1h 40m 41s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 40s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 53s
✔️ build-push-container-cifmw-client SUCCESS in 36m 40s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 13s

@lpiwowar
Copy link
Contributor Author

recheck

lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Dec 18, 2024
The test-operator is using Jobs to spawn test pods even though it does
not use any features of this k8s object. Plus usage of the Jobs requires
creation of ServiceAccount in the target namespaces. In order to be able
to create a new, SA the test-oprator has to have a rights to create new
roles and rolebindings which in our case makes the attack surface
larger.

This patch drops the usage of Jobs and moves to Pods.

Depends-On: openstack-k8s-operators/ci-framework#2604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant