Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include_role task #731

Closed
wants to merge 1 commit into from
Closed

Fix include_role task #731

wants to merge 1 commit into from

Conversation

dasm
Copy link
Contributor

@dasm dasm commented Oct 26, 2023 •
edited
Loading

include_role uses "name: [name of role]" as a way to import role.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

@dasm
Fix include_role task
40fba5a 
include_role uses "name: [name of role]" as a way to import role.
@dasm dasm requested a review from stuggi October 26, 2023 22:36
@openshift-ci openshift-ci bot requested review from marios and son-vyas October 26, 2023 22:36
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6f120829719646f0bf90fcb530a2a15a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 03m 14s
✔️ noop SUCCESS in 0s
❌ podified-multinode-edpm-e2e-nobuild-tagged-crc FAILURE in 51m 54s
✔️ cifmw-molecule-edpm_prepare SUCCESS in 4m 52s

@cjeanner
Copy link
Collaborator

/approve

note: both work, the role param was probably exchange without proper deprecation, and is still valid.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cjeanner
cjeanner reviewed Oct 27, 2023
View reviewed changes
ci_framework/roles/edpm_prepare/tasks/main.yml
@@ -250,7 +250,7 @@
vars:
cifmw_install_ca_bundle_src: "{{ cifmw_edpm_prepare_basedir }}/tls-ca-bundle.pem"
ansible.builtin.include_role:
role: install_ca
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this will probably conflict with #737

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems that it's not a valid solution. Let's go with yours revert.

@dasm dasm closed this Oct 27, 2023
@cjeanner cjeanner deleted the bugfix branch November 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjeanner cjeanner cjeanner left review comments

@stuggi stuggi Awaiting requested review from stuggi

@marios marios Awaiting requested review from marios

@son-vyas son-vyas Awaiting requested review from son-vyas

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dasm @cjeanner