Improve logs #462
Merged
Improve logs #462
+9
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a couple of additional log entries.
There are a couple of places where the logs will say "Deployment successfully reconciled" when they are actually referring to CRs. This is quite confusing, because Deployment is an OpenShift object which we are not using. This patch changes this so we stop saying Deployment and instead refer to the specific CR we are talking about.
There are a number of placeholder reconciliation method that do nothing except logging messages of how the method has been entered and exited. This is useless code as well as clutter in the logs, so this patch removes them. Affected methods are: - reconcileInit - reconcileUpdate - reconcileUpgrade There are instances where reconcileInit is actually doing things, and in those cases methods were left untouched.
Closed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ASBishop, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks good and in line with what we did in other operators. |
openshift-merge-bot
bot
merged commit fcec1d5
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of Gorka's PR #365. In addition to rebasing, it drops one commit that's no longer required (the change was made in another PR).