Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service selector for openstackclient pod #186

Merged

Conversation

cescgina
Copy link
Contributor

Recently the openstackclient pod moved to using app to service as
a selector, this change updates the check in the tests to use the right
label.

It appears this change in openstack-operator was the trigger:
openstack-k8s-operators/openstack-operator#502

Recently the openstackclient pod moved to using app to service as
a selector, this change updates the check in the tests to use the right
label.
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b490188b59b046d18da802e506004601

data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 23m 38s
data-plane-adoption-github-rdo-centos-9-extracted-crc FAILURE in 35m 46s

@cescgina cescgina requested review from jistr and marios October 27, 2023 12:54
@fao89
Copy link
Contributor

fao89 commented Oct 27, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b25fc4093bec42c7baf8c65da38ae819

data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 19m 40s
data-plane-adoption-github-rdo-centos-9-extracted-crc FAILURE in 37m 11s

Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
but waiting for merge on https://review.rdoproject.org/r/c/rdo-jobs/+/50667
and recheck here

@cescgina
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/948411c5c039439f913e9e918e579a20

data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 20m 15s
✔️ data-plane-adoption-github-rdo-centos-9-extracted-crc SUCCESS in 1h 43m 56s

@cescgina
Copy link
Contributor Author

Merging as at least we have one working job to gate PRs with this fix, investigating now the failure reason for the single-node job

@marios
Copy link
Contributor

marios commented Oct 30, 2023

the new extracted job passes here (the older job fails on placement for cert issue which is cix'd and almost fixed OSPCIX-104

@marios marios merged commit 2b2174d into openstack-k8s-operators:main Oct 30, 2023
1 check passed
@cescgina cescgina deleted the fix_openstack_client_check branch October 30, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants