-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rdo|rhoso-openvswitch wrapper to pin versions #507
base: main
Are you sure you want to change the base?
Use rdo|rhoso-openvswitch wrapper to pin versions #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Related change in edpm-ansible: openstack-k8s-operators/edpm-ansible#686 |
If openvswitch3.N is pinned, rdo-openvswitch is still upgraded, which replaces openvswitch3.N with openvswitch.N+1. But if the wrapper is pinned, then it doesn't.
684cb4d
to
2b87d85
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/47701c3388a3458c870d8eb0dcae5f4b ❌ data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 06m 53s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure is related:-
TASK [dataplane_adoption : Create OpenStackDataPlaneNodeSet] *******************
fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'distribution' is undefined. 'distribution' is undefined\n\nThe error appears to be in '/home/zuul/src/github.com/openstack-k8s-operators/data-plane-adoption/tests/roles/dataplane_adoption/tasks/main.yaml': line 135, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create OpenStackDataPlaneNodeSet\n ^ here\n"}
seems need to add defaults in tests/roles/common_defaults/defaults/main.yaml |
If openvswitch3.N is pinned, rdo-openvswitch is still upgraded, which replaces openvswitch3.N with openvswitch.N+1. But if the wrapper is pinned, then it doesn't.