Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rdo|rhoso-openvswitch wrapper to pin versions #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Jun 25, 2024

If openvswitch3.N is pinned, rdo-openvswitch is still upgraded, which replaces openvswitch3.N with openvswitch.N+1. But if the wrapper is pinned, then it doesn't.

@booxter booxter marked this pull request as draft June 25, 2024 18:08
Copy link

@mtomaska mtomaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tests/roles/dataplane_adoption/tasks/main.yaml Outdated Show resolved Hide resolved
@booxter booxter requested a review from jistr June 26, 2024 14:02
@booxter booxter marked this pull request as ready for review June 26, 2024 14:02
@booxter
Copy link
Contributor Author

booxter commented Jun 26, 2024

Related change in edpm-ansible: openstack-k8s-operators/edpm-ansible#686

If openvswitch3.N is pinned, rdo-openvswitch is still upgraded, which
replaces openvswitch3.N with openvswitch.N+1. But if the wrapper is
pinned, then it doesn't.
@booxter booxter force-pushed the use-rpm-wrapper-to-pin-ovs branch from 684cb4d to 2b87d85 Compare July 2, 2024 16:33
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/47701c3388a3458c870d8eb0dcae5f4b

data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 06m 53s
data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 09m 35s
✔️ adoption-docs-preview SUCCESS in 1m 07s

Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is related:-
TASK [dataplane_adoption : Create OpenStackDataPlaneNodeSet] *******************
fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'distribution' is undefined. 'distribution' is undefined\n\nThe error appears to be in '/home/zuul/src/github.com/openstack-k8s-operators/data-plane-adoption/tests/roles/dataplane_adoption/tasks/main.yaml': line 135, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create OpenStackDataPlaneNodeSet\n ^ here\n"}

https://logserver.rdoproject.org/07/507/2b87d851d8b9f7e21252b6d10d6b3a8c02f7a6ce/github-check/data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph/9a1192d/controller/data-plane-adoption-tests-repo/data-plane-adoption/tests/logs/test_minimal_out_2024-07-02T14:37:14EDT.log

@karelyatin
Copy link
Contributor

Failure is related:- TASK [dataplane_adoption : Create OpenStackDataPlaneNodeSet] ******************* fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'distribution' is undefined. 'distribution' is undefined\n\nThe error appears to be in '/home/zuul/src/github.com/openstack-k8s-operators/data-plane-adoption/tests/roles/dataplane_adoption/tasks/main.yaml': line 135, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create OpenStackDataPlaneNodeSet\n ^ here\n"}

https://logserver.rdoproject.org/07/507/2b87d851d8b9f7e21252b6d10d6b3a8c02f7a6ce/github-check/data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph/9a1192d/controller/data-plane-adoption-tests-repo/data-plane-adoption/tests/logs/test_minimal_out_2024-07-02T14:37:14EDT.log

seems need to add defaults in tests/roles/common_defaults/defaults/main.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants