Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refined Compute adoption procedure #529

Merged

Conversation

klgill
Copy link
Contributor

@klgill klgill commented Jul 12, 2024

** Default cell is renamed to `cell1` (in a multi-cell setup, it should become indexed as the last cell instead).
** RabbitMQ transport URL no longer uses `guest`.
* The cell1 `nova` database and username become `nova_cell1`.
* The default cell is renamed to `cell1`. In a multi-cell setup, it should become indexed as the last cell instead.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeanMooney I’m not sure if we need to say “In a multi-cell setup, it should become indexed as the last cell instead.” This procedure is focused on a single cell configuration, so I suggest staying focused on that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is debatable.
the Bogdan is currently working on the support for multiple compute cells

we are generally trying to remove the single cell and multi-cell disticiton form all of our docs

on of the open questions we are currently resolving is if we can have a common adoption procedure or not.

all OpenStack deployments have at least 2 cells

cell-0 which is reserved for instance that could not be scheduled to any host and some other internal nova usage and a compute cell typically called "cell-1" or sometimes "default"

when i refer to a comptue cell i mean a cell other then cell-0
or endgoal is to have one procedure for both cases since we will no longer be maintaining a difference in our docs for a cloud that only has 2 cells (cell-0 and either cell-1 or default) and a cloud that has more the two cells.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klgill for context this is the current work in flight to update the procedure to work with multiple compute cells #517

Copy link
Contributor

@bogdando bogdando Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have discovered a regression in docs, which makes it disconnected from tests, see #490 (comment) (https://issues.redhat.com/browse/OSPRH-8656)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the multi-cell work in progress, I can make it rebasing on top of this, hopefully. Ideally though I agree this should be blocked on finishing the multi-cell guide in the PR that Sean has linked.

However, if this need to proceed now, feel free to just omit any confusing sections and statements related to multi-cell arch, as it was in flux by the time of writing, and still it is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdando This procedure is intended to be published in the adoption guide async after GA. It will likely be published before Feature Release 1, when the multi-cell feature is finished.
I'm inclined to do as you suggested: Remove any statements related to multi-cell and then merge. Let me know if anything else should be done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, i think this PR contains a bunch of refinements that are unrelated to the multi-cell situation? So ideally we wouln't prevent this from landing altogether.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @SeanMooney @bogdando @jistr : I hid/removed all multi-cell references. Let me know if I missed anything, or if you have additional comments on this procedure in general. Thank you!

@klgill klgill requested a review from SeanMooney July 12, 2024 19:11
@bogdando bogdando self-requested a review July 15, 2024 14:19
Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide refactoring should be done after fixing a regression discovered here #490 (comment)

@klgill klgill force-pushed the Docs-Refine-Compute_Adoption branch from b36713f to 676fb8a Compare July 16, 2024 16:53
Copy link

@gregraka gregraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klgill solid effort. A few nits that you can take or leave!

@klgill klgill force-pushed the Docs-Refine-Compute_Adoption branch from 6bd5800 to c2da16f Compare July 24, 2024 17:13
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b1acc1ef0df84e6fa5fcdc8cb25e9b73

adoption-docs-preview POST_FAILURE in 1m 24s

@klgill
Copy link
Contributor Author

klgill commented Jul 24, 2024

recheck

@klgill klgill merged commit ad9f607 into openstack-k8s-operators:main Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants