Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the logic for wait for glance pods #676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

simplify the logic for wait for glance pods #676

wants to merge 1 commit into from
+1 −13

Conversation

katarimanojk
Copy link

@katarimanojk katarimanojk commented Oct 24, 2024 •
edited
Loading

simplify the wait logic for glance pods

@fmount
Copy link
Contributor

fmount commented Oct 24, 2024

simply the logic for wait for glance pods

s/simply/simplify

fmount
fmount reviewed Oct 24, 2024
View reviewed changes
tests/roles/glance_adoption/tasks/check_glance.yaml
fi
done
exit $code
oc wait pod --for condition=Ready --selector=service=glance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change as long as CI is happy with that. I think the main point here was about wait for all the Glance pods to reach Running phase, but this looks better. Thanks Manoj!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, wait for pod condition 'Ready' is simplest way to ensure that all the containers of the pod are in 'Running' phase and pod is able to serve requests.

@fmount
Copy link
Contributor

fmount commented Oct 24, 2024

@katarimanojk can you check the linter issue and rebase this patch?

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b1679a81a1624e5d916e71cc2cc33bc0

❌ adoption-standalone-to-crc-ceph FAILURE in 2h 46m 13s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 43m 18s

fmount
fmount approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fmount fmount changed the title simply the logic for wait for glance pods simplify the logic for wait for glance pods Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmount fmount fmount approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katarimanojk @fmount