ospdo adoption mariadb copy #690
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/261ef1c49ddf4ef1b75233918601ae13 ❌ adoption-standalone-to-crc-ceph FAILURE in 1h 40m 39s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/628b424ece0649c09675c506e6f82850 ❌ adoption-standalone-to-crc-ceph FAILURE in 56m 04s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eff987a62645484f972eb0bb51e7295a ❌ adoption-standalone-to-crc-ceph FAILURE in 1h 59m 44s |
pinikomarov
force-pushed
the
ospdo_adoption_mariadb_copy
branch
from
5ae43fd
to
d567838
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/117e2a8986a74432aa827081eb5cfc71 ❌ adoption-standalone-to-crc-ceph FAILURE in 1h 44m 46s |
pinikomarov
force-pushed
the
ospdo_adoption_mariadb_copy
branch
from
d567838
to
fb1bcc9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4908283f91b54b88bbcb9083019ff008 ❌ adoption-standalone-to-crc-ceph FAILURE in 1h 50m 03s |
| @@ -19,6 +19,7 @@ | |||
| PODIFIED_MARIADB_IP={{ podified_mariadb_ip_result.stdout }} | |||
| PODIFIED_CELL1_MARIADB_IP={{ podified_cell1_mariadb_ip_result.stdout }} | |||
| PODIFIED_DB_ROOT_PASSWORD="{{ podified_db_root_password }}" | |||
| MARIADB_CLIENT_ANNOTATIONS="-n {{ rhoso_namespace }}" | |||
There was a problem hiding this comment.
We can't set this variable here, it will override the setting from env_vars_src.yaml. Both env_vars_src.yaml and env_vars_dst.yaml are sourced one after another. AFAIU we need to be able to use mariadb_copy_shell_vars_dst and mariadb_copy_shell_vars_src together. Also think about how this translates to the docs. There are no distinctions between src/dst vars. MARIADB_CLIENT_ANNOTATIONS is set once and stays that way.
Does the OSPDO use case require running the data copy pods in both namespaces?
There was a problem hiding this comment.
OK , I'll leave the MARIADB_CLIENT_ANNOTATIONS as it was before and not override it.
I'll add the correct namespace throughout the needed oc commands...
| @@ -5,7 +5,7 @@ | |||
| {{ mariadb_copy_shell_vars_dst }} | |||
|
|
|||
| # Test connection to podified DBs (show databases) | |||
| oc run mariadb-client --image $MARIADB_IMAGE -i --rm --restart=Never -- \ | |||
| oc run mariadb-client ${MARIADB_CLIENT_ANNOTATIONS} --image $MARIADB_IMAGE -i --rm --restart=Never -- \ | |||
There was a problem hiding this comment.
This change needs to be done in docs too.
There was a problem hiding this comment.
ok will add those to my pr
pinikomarov
force-pushed
the
ospdo_adoption_mariadb_copy
branch
from
fa34bb1
to
14ad911
Compare
pinikomarov
force-pushed
the
ospdo_adoption_mariadb_copy
branch
from
14ad911
to
5e4655a
Compare
| @@ -19,6 +19,7 @@ | |||
| PODIFIED_MARIADB_IP={{ podified_mariadb_ip_result.stdout }} | |||
| PODIFIED_CELL1_MARIADB_IP={{ podified_cell1_mariadb_ip_result.stdout }} | |||
| PODIFIED_DB_ROOT_PASSWORD="{{ podified_db_root_password }}" | |||
| MARIADB_CLIENT_ANNOTATIONS="-n {{ rhoso_namespace }}" | |||
There was a problem hiding this comment.
OK , I'll leave the MARIADB_CLIENT_ANNOTATIONS as it was before and not override it.
I'll add the correct namespace throughout the needed oc commands...
Add Director Operator mariadb_copy scripts for adoption
Related CI patch and background:
https://gitlab.cee.redhat.com/ci-framework/ci-framework-jobs/-/merge_requests/966
PRs submitted together :
related PR list
Jiras:
https://issues.redhat.com/browse/OSPRH-1891
https://issues.redhat.com/browse/OSPRH-2984