Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry login docs #705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Nov 6, 2024

@fao89 fao89 requested review from slagle and klgill November 6, 2024 19:47
EOF
----

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+
* Replace `<base64_encoded_username>` and `<base64_encoded_password>` with strings that are base64-encoded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the plus sign should immediately follow the four dashes: ----


. Create a secret for the Red Hat registry:
+
[source,bash]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[source,bash]

Removing for consistency.

Copy link
Contributor

@klgill klgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor changes.

ref OSPRH-11281

Signed-off-by: Fabricio Aguiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants