Multi cell database/mq adoption #746
Conversation
bogdando
force-pushed
the
multi_cell_database
branch
from
3323bbf to
a1207eb
Compare
|
testproject https://review.rdoproject.org/r/c/testproject/+/55584 PASSED |
bogdando
added
the
check-before-merge/depends-on
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ff2fa0079d2d4d0f9d107db215021a87 ✔️ noop SUCCESS in 0s |
docs_user/modules/proc_migrating-databases-to-mariadb-instances.adoc
Outdated
Show resolved
Hide resolved
bogdando
force-pushed
the
multi_cell_database
branch
from
0ba8ce7 to
cd5b8f9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2bf5c26d9ce042488b038c87505a0f82 ✔️ noop SUCCESS in 0s |
bogdando
force-pushed
the
multi_cell_database
branch
3 times, most recently
from
c392e11 to
006e247
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ef997d9bd22a422fa0a81831c10ce76f ✔️ noop SUCCESS in 0s |
bogdando
force-pushed
the
multi_cell_database
branch
from
006e247 to
55aec9f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/221b8eaa480445db948ba454fc1dc6d9 ✔️ noop SUCCESS in 0s |
|
recheck |
bogdando
force-pushed
the
multi_cell_database
branch
from
55aec9f to
ee3defd
Compare
|
This change depends on a change that failed to merge. Change https://review.rdoproject.org/r/c/rdo-jobs/+/53192 is needed. |
bogdando
force-pushed
the
multi_cell_database
branch
from
ee3defd to
03ce37c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/28720608befb44c49d0f76f95466684b ✔️ noop SUCCESS in 0s |
bogdando
force-pushed
the
multi_cell_database
branch
3 times, most recently
from
505e4e8 to
8d81b48
Compare
tests/roles/backend_services/templates/openstack_control_plane.j2
Outdated
Show resolved
Hide resolved
tests/roles/backend_services/templates/openstack_control_plane.j2
Outdated
Show resolved
Hide resolved
docs_user/modules/proc_retrieving-topology-specific-service-configuration.adoc
Show resolved
Hide resolved
bogdando
force-pushed
the
multi_cell_database
branch
from
8d81b48 to
cdff544
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/513df93417f943f8bc8b6d3849192150 ✔️ noop SUCCESS in 0s |
Assume a single cell1 yet. Remove edpm_computes and computes env var from tests as it is not multi-cell aware, and should be no longer needed. The docs still use that env var, it will be removed in multi-cell adoption follow up, where we also cover EDPM multi-cell adoption. This is required as rhe rdo-jobs dependency introduces that change for edpm_nodes and provides a common base for this and future multi-cell follow ups. Signed-off-by: Bohdan Dobrelia <[email protected]>
Signed-off-by: Bohdan Dobrelia <[email protected]>
Signed-off-by: Bohdan Dobrelia <[email protected]>
Co-authored-by: Katie Gilligan <[email protected]>
bogdando
force-pushed
the
multi_cell_database
branch
from
ed36f41 to
b6545ed
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/09a8bc90c11c465a8651d8c59c6b2246 ✔️ noop SUCCESS in 0s |
|
https://review.rdoproject.org/r/c/testproject/+/54199 has periodic-adoption-multinode-to-crc-no-ceph https://softwarefactory-project.io/zuul/t/rdoproject.org/build/4560c2e175f0410591ddd23a3540c631 : FAILURE in 3h 42m 49s (swift migration post-adoption) |
|
recheck "Trying to pull quay.io/freeipa/freeipa-server:fedora-41.." |
bogdando
removed
the
check-before-merge/depends-on
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dea0d03a0ebf48d6aff5c5faee49eb61 ✔️ noop SUCCESS in 0s |
bogdando
added
check-before-merge/depends-on
|
standalone CI jobs need the same adjustments as I did for multinode |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/50a66f96f54749d9843a3493e1b9e8ee ✔️ noop SUCCESS in 0s |
|
recheck Keystone Connection aborted |
|
please merge |
|
This is large and it makes the user-facing workflow around DB copy pretty complex, but my +2 stands as i don't think we can do considerably better with the current higher level approach of sticking to documented procedure only. I would be interested in more context around the cell renaming (why is it necessary) but that may be best for a f2f call. I would like to get a review from one more core dev and then we can merge. |
|
The history here is long but after unwrapping it in the Github UI i see this was already reviewed by me, Katie, Pini and Gibi. Going for the merge. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jistr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jistr
removed
the
check-before-merge/depends-on
|
/lgtm |
openshift-merge-bot
bot
merged commit 217f280
into
openstack-k8s-operators:main
Declare RUN_OVERRIDES before it is used.
Use env vars instead of docs generation conditions to reuse the same
code in tests:
tripleo
RHOSO18_NAMESPACE or OSPDO_NAMESPACE. Remove unused rhoso18 ns value
(only in these guide).
Illustrate how commands in scripts could have comments
that become (almost as is) native ascii docs foot-notes.
When copying code into docs, the minimal adjustments will
be needed, like adding '$' prefix (or '>' for multiline commands).
Provide a static multi-cell config for databases and messaging
for adoption guide and tests, which comprises a 3 cells.
Default becomes cellX (or it can be imported as is, for a multi-cell
case only)
cell1 becomes mapped to openstack-cell1 osdp node set
cell2 becomes mapped to openstack-cell2 osdp node set, etc.
cellX (X=3 here) becomes mapped to openstack-cell3. Alternatively,
default cell retains its name for the openstack-default osdpns
mapping
Evaluate podified MariaDB passwords for cells from osp-secret
to align the tests with documented commands. Remove no longer
needed podified DB password variable.
Make ansible and shell variables compute cells aware.
Rework vars and secrets YAML values for the source and edpm
nodes to not confuse its different naming schemes for cells
in OSP/TripleO and RHOSO.
Remove cached fact for pulled OSP configuration as it can no longer
be generated in a multi-cell setup, where related shell variables
become bash arrays.
Simplify ENV headers management by collecting in a single place.
Adjust storage/storageRequests values to make it better fitting
a multi-cell test scenarios. Also provide values in docs and
add a comment to adjust them as needed.
Remove source_db_root_password as it is directly evaluated from
tripleo passwords into an env var.
Run mysql commands in individual pods.
Finished pods take time to terminate, avoid errors where
consequent mysql commands failing because the old and new pod use the
same name.
Rename nodesets to openstack-cell1, which is needed for adoption of
remaining multi-cell aware services in a follow up.
Make edpm_nodes input multi-cell aware.
Assume a single cell1 yet.
Remove edpm_computes and computes env var
from tests as it is not multi-cell aware, and should be no longer
needed. The docs still use that env var, it will be removed in
multi-cell adoption follow up, where we also cover EDPM multi-cell
adoption.
This is required as rhe rdo-jobs dependency introduces that
change for edpm_nodes and provides a common base for this and future
multi-cell follow ups.
Closes: https://github.com/openstack-k8s-operators/data-plane-adoption/issues/184
Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/56389
Required-By: https://review.rdoproject.org/r/c/rdo-jobs/+/56116
Jira: #OSPRH-6548