Skip IPAM configuration if it is already configured #804
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
jistr
reviewed
Feb 6, 2025
Run ensure IPAM is configured task only when ipam configuration is needed, otherwise skip re-applying netconfig to not overwrite it with default values. Default configure_ipam value is false. Resolves: OSPRH-13659
ciecierski
force-pushed
the
ipam_configuration
branch
from
3febbdc to
079340d
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jistr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 52d5355
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run ensure IPAM is configured task only when ipam configuration is needed, otherwise skip re-applying netconfig to not overwrite it with default values.
Default configure_ipam bool value is true.
Resolves: OSPRH-13659