switch to structured logging #382
Conversation
|
Hi @pinikomarov. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/57e28fd10607443aa8fdb24d1e68a8b2 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 27s |
|
/ok-to-test |
|
|
||
| // getlog returns a logger object with a prefix of "conroller.name" and aditional controller context fields | ||
| func GetLog(ctx context.Context, controller string) logr.Logger { | ||
| return log.FromContext(ctx).WithName("Controllers").WithName(controller) |
There was a problem hiding this comment.
same comment as from openstack-k8s-operators/openstack-ansibleee-operator#227
|
/hold In order to avoid a merge conflict, we need to hold this until #303 can be merged. PR 303 is the top priority in order to get merged at this time. |
|
/unhold rdoproject.org/github-check jobs should be passing now. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pinikomarov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
pinikomarov
force-pushed
the
structured_logging
branch
from
ae52d43 to
626146a
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e68562589fe6418a8a33be4ea602870a ❌ openstack-k8s-operators-content-provider FAILURE in 7m 43s |
|
code testing seems to have an issue : |
|
/retest |
pinikomarov
force-pushed
the
structured_logging
branch
from
626146a to
d1f32f0
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7604f7aab5284ca5bbf7047289ed0100 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 52s |
pinikomarov
force-pushed
the
structured_logging
branch
from
d1f32f0 to
7f3af85
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/739bfd55b71f4cdda8a32c4d5e5a7339 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 44s |
update logging update tests logging update logging update logging
pinikomarov
force-pushed
the
structured_logging
branch
from
477e3c7 to
bb0cf10
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/8977609fb35d44d3b5b9ed126ff4552a ❌ openstack-k8s-operators-content-provider FAILURE in 5m 20s |
|
@pinikomarov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
continued here : #488 |
This automatically adds additional fields like reconcile_id etc.. from the controller context.
before :
2023-05-18T01:53:14+03:00 INFO controllers.KeystoneAPI Reconciled Service init successfullyafter:
2023-05-18T02:00:28+03:00 INFO Controllers.KeystoneAPI Reconciled Service init successfully {"controller": "keystoneapi", "controllerGroup": "keystone.openstack.org", "controllerKind":"KeystoneAPI", "KeystoneAPI": {"name":"keystone","namespace":"openstack"}, "namespace": "openstack", "name": "keystone", "reconcileID": "512a4d9b-f31d-4fa4-a4cc-cd6c13e4455d"}*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.
*example logs lines are currently from keystone operator #220_patch until this operator deployment patch testing is is done