Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Change the network names to lower case in samples #617

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Change the network names to lower case in samples #617

merged 1 commit into from
Jan 31, 2024

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Jan 24, 2024

This aligns with the network names used in control plane network attachments and metallb IPAddressPool etc.

@rabi
Copy link
Contributor Author

rabi commented Jan 24, 2024

/hold

@openshift-ci openshift-ci bot requested review from frenzyfriday and slagle January 24, 2024 02:46
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f71119e4f7ed44e1b9d23e4863425fee

✔️ openstack-k8s-operators-content-provider SUCCESS in 46m 25s
podified-multinode-edpm-deployment-crc FAILURE in 21m 58s
cifmw-crc-podified-edpm-baremetal FAILURE in 17m 48s

@rabi
Copy link
Contributor Author

rabi commented Jan 25, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/03f8c24de18741aab49393ec94d6004f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 57s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 4m 10s

@rabi
Copy link
Contributor Author

rabi commented Jan 25, 2024

recheck crc could not start, no logs

@fao89
Copy link
Collaborator

fao89 commented Jan 31, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 31, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 99237ff into openstack-k8s-operators:main Jan 31, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants