Refacter service secrets function

[bshephar]

This change refactors the generateServiceSecrets function to deduplicate code and move logic related to vhosts and templateParameters into dedicated functions.

[bshephar]

I know this adds a new style of testing. But I feel like Heat operator is particularly difficult to test because of the Gophercloud dependency. So we either mock the entire thing, or setup an API server to send OpenStack API like responses. Both of those options feel like a lot of work, so I propose that we instead try to make our code more natively testable by splitting up logic into smaller functions and then using table driven tests to validate their functionality.

In this particular case, the table driven test allowed for me to pass TLS and Non TLS scenarios quickly, while in envtest we just validate the resulting secret data for one off those scenarios. I think if we take this same style and logic and apply it to the rest of the repo, we can improve our test coverage here without the additional burden of the OpenStack API responses.

[bshephar]

Kuttl is failing due to the issue with the latest go-toolset in Go 1.21. We'll need to wait for that to be fixed to recheck on this one.

[stuggi]

we've put in a custom image in place, the issue should be gone

[stuggi]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bshephar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment