Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index the customServiceConfigSecrets for use in the Secret lookup #461

Conversation

bshephar
Copy link
Collaborator

@bshephar bshephar commented Oct 28, 2024

This change ensures the customServiceConfigSecrets value is indexed for when we need to use it in the FindObjectsForSrc function

closes OSPRH-10267

@openshift-ci openshift-ci bot requested review from olliewalsh and stuggi October 28, 2024 05:41
@bshephar bshephar marked this pull request as draft October 28, 2024 05:43
This change ensures the customServiceConfigSecrets value is indexed for
when we need to use it in the FindObjectsForSrc function

Signed-off-by: Brendan Shephard <[email protected]>
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor

fmount commented Oct 28, 2024

/test heat-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit 0d5af8b into openstack-k8s-operators:main Oct 28, 2024
7 checks passed
@fao89
Copy link
Contributor

fao89 commented Oct 28, 2024

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@fao89: new pull request created: #462

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants