Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the relevant http headers when Horizon is served as https #313

Merged

Conversation

deshipu
Copy link
Contributor

@deshipu deshipu commented Apr 8, 2024

There is a number of headers we can enable in Django configuration that make the site somewhat safer.

@openshift-ci openshift-ci bot requested review from olliewalsh and stuggi April 8, 2024 08:52
@deshipu deshipu force-pushed the https-headers branch 2 times, most recently from 9860466 to a04dc51 Compare April 8, 2024 09:04
@deshipu
Copy link
Contributor Author

deshipu commented Apr 8, 2024

/retest

@xtmprsqzntwlfb xtmprsqzntwlfb self-requested a review April 9, 2024 17:01
Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

There is a number of headers we can enable in Django configuration
that make the site somewhat safer.

See https://docs.djangoproject.com/en/3.2/topics/security/#ssl-https
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, deshipu, hjensas, olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bshephar,olliewalsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8e29e92 into openstack-k8s-operators:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants