Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transporturl] support TLS, watch name rabbitmq cluster resource and EnvTests #153

Merged

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Dec 4, 2023

support tls query
The rabbitmq transport url requested needs to be in the following format for tls:
rabbit://<user>:<pwd>@<service>:5671/?ssl=1

  • pass query ?ssl=1/0 depending of enabled disabled
  • When tls is enabled a different port is used by the cluster. The information is part of the rabbitmq secret. Lets get the port information always from the secret.

watch for named rabbit cluster
When updates are performed to the rabbitmq cluster, like change from non tls to tls configuration the transporturl has to reconcile. This adds functionality to the transporturl controller to watch for the named rabbitmq cluster.

Add envtest for default and tls use case

Jira: OSPRH-1919

The rabbitmq transport url requested needs to be in the
following format for tls:
rabbit://<user>:<pwd>@<service>:5671/?ssl=1

* pass query `?ssl=1/0` depending of enabled disabled
* When tls is enabled a different port is used by the cluster.
  The information is part of the rabbitmq secret. Lets get the
  port information always from the secret.

Jira: OSPRH-1919
@openshift-ci openshift-ci bot added the approved label Dec 4, 2023
@stuggi stuggi requested review from Deydra71 and vakwetu and removed request for frenzyfriday December 4, 2023 07:50
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/da73b5ac692f415b993dfe765d4d7955

openstack-k8s-operators-content-provider FAILURE in 15m 00s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi
Copy link
Contributor Author

stuggi commented Dec 4, 2023

/test infra-operator-build-deploy-kuttl

2 similar comments
@stuggi
Copy link
Contributor Author

stuggi commented Dec 4, 2023

/test infra-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Dec 4, 2023

/test infra-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor Author

stuggi commented Dec 4, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a39d166bd74541aab59b1324ec291177

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 02m 22s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 8m 20s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 11m 56s

@stuggi
Copy link
Contributor Author

stuggi commented Dec 5, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/39e6f57d798c4855b68e1447e868ba9c

✔️ openstack-k8s-operators-content-provider SUCCESS in 42m 03s
podified-multinode-edpm-deployment-crc FAILURE in 22m 22s
cifmw-crc-podified-edpm-baremetal FAILURE in 15m 12s

@stuggi
Copy link
Contributor Author

stuggi commented Dec 5, 2023

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/943d670579404d0fbd78dd8f8260c770

openstack-k8s-operators-content-provider FAILURE in 15m 09s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi
Copy link
Contributor Author

stuggi commented Dec 6, 2023

recheck

@olliewalsh
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5eb2ad7 into openstack-k8s-operators:main Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants