Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow memcached to listen to both TLS and non-TLS #212

Merged

Conversation

dciabrin
Copy link
Contributor

@dciabrin dciabrin commented Apr 11, 2024

When memcached is configured for exposing its endpoint over TLS, some clients still require accessing in via non-TLS. Update the TLS configuration to expose the TLS endpoint on port 11212 while keeping non-TLS accesses on port 11211. This matches what was configured by TripleO.

Updated kuttl tests to avoid multiple TestAssert in the same test as only the last one is executed. Also rename the assert files to give time to the resource to become ready before running the assert scripts to avoid spurious logs.

Jira: OSPRH-3568

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8e9f1e6921d44bcfb565bace13b1edab

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 15s
podified-multinode-edpm-deployment-crc FAILURE in 1h 02m 29s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 13m 39s

@dciabrin
Copy link
Contributor Author

/test infra-operator-build-deploy-kuttl

2 similar comments
@stuggi
Copy link
Contributor

stuggi commented Apr 12, 2024

/test infra-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Apr 13, 2024

/test infra-operator-build-deploy-kuttl

@lewisdenny lewisdenny removed their request for review April 14, 2024 22:41
@dciabrin
Copy link
Contributor Author

/test infra-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Apr 15, 2024

recheck

@stuggi
Copy link
Contributor

stuggi commented Apr 15, 2024

/test infra-operator-build-deploy-kuttl

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9af0118a0f384c82877f920ff2c59b4b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 11s
podified-multinode-edpm-deployment-crc FAILURE in 28m 12s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 05m 05s

@stuggi
Copy link
Contributor

stuggi commented Apr 16, 2024

/test infra-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Apr 16, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2c77ef42b4ed4745821cbd317169bd39

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 39s
podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 41s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 05m 53s

@stuggi
Copy link
Contributor

stuggi commented Apr 16, 2024

/test infra-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Apr 16, 2024

keystone bootstrap jobs fail. we try to get the service operator bump in the openstack-operator landed to have a possible fix for mariadb added.

@stuggi
Copy link
Contributor

stuggi commented Apr 16, 2024

/test infra-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Apr 16, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e66085d1dea6449da9ed34659f608c69

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 27s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 9m 15s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 07m 59s

When memcached is configured for exposing its endpoint over TLS,
some clients still require accessing in via non-TLS.
Update the TLS configuration to expose the TLS endpoint on port
11212 while keeping non-TLS accesses on port 11211. This matches
what was configured by TripleO.

Updated kuttl tests to avoid multiple TestAssert in the same
test as only the last one is executed. Also rename the assert
files to give time to the resource to become ready before
running the assert scripts to avoid spurious logs.

Jira: OSPRH-3568
@dciabrin
Copy link
Contributor Author

New revision to fix infra-operator-build-deploy-kuttl failure, as spotted by @stuggi

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dciabrin, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cf57fc7 into openstack-k8s-operators:main Apr 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants