Add AntiAffinity and NodeSelector capabilities to memcached #258
Conversation
| // run on the same worker node. If this is not possible | ||
| // the get still created on the same worker node. | ||
| sfs.Spec.Template.Spec.Affinity = affinity.DistributePods( | ||
| common.AppSelector, |
There was a problem hiding this comment.
one thing the common.Appselector https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/const.go#L22 is "service", not app. so the label above use the same const
There was a problem hiding this comment.
the const then should also be used in the service https://github.com/openstack-k8s-operators/infra-operator/blob/main/pkg/memcached/service.go#L15
lmiccini
force-pushed
the
memcached-selector
branch
from
0309908 to
8e55a15
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 72bf12d
into
openstack-k8s-operators:main
…d-selector Add AntiAffinity and NodeSelector capabilities to memcached
…d-selector Add AntiAffinity and NodeSelector capabilities to memcached
Related: https://issues.redhat.com/browse/OSPRH-9295