Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename InstanceHA to InstanceHa and use configmap for containerImage #273

Merged

Conversation

lmiccini
Copy link
Contributor

This commit renames the InstanceHA occurrences into InstanceHa to comply with the openstack-operator's openstackversion naming (case) convention.

We also take the chance and use a configmap created by the openstack-operator to get the containerImage, so to orchestrate its update.

This commit renames the InstanceHA occurrences into InstanceHa
to comply with the openstack-operator's openstackversion naming
(case) convention.

We also take the chance and use a configmap created by
the openstack-operator to get the containerImage, so
to orchestrate its update.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ab29d70e914a46dbadae9bc3b31ee4ba

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 38s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 18s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 6m 26s

@lmiccini
Copy link
Contributor Author

recheck

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4066f2e into openstack-k8s-operators:main Sep 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants