Increase POLL interval to avoid race with check_kdump #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit increases the default value of 'POLL' from 30s to 45s. The reason is that the check_kdump functionality has an internal hard-coded timeout of 30s and this may induce race conditions if POLL is set to the same value. A warning has been added to make sure users are notified if POLL=30s. Finally, we take the chance to normalize the retcode for bmh_fencing.
stuggi
approved these changes
Oct 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3d0bae9
into
openstack-k8s-operators:main
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit increases the default value of 'POLL' from 30s to 45s.
The reason is that the check_kdump functionality has an internal hard-coded timeout of 30s and this may induce race conditions if POLL is set to the same value.
A warning has been added to make sure users are notified if POLL=30s.
Finally, we take the chance to normalize the retcode for bmh_fencing.