[BGP] Fix FRRConfiguration cleanup #340
Conversation
Currently the process of processing the FRRConfigurations is: * get a list of all pods in the ctlplane namespace * filter that list to the pods which have a secondary IF configured * run through that list of pods with an IF attached and validate if there is a change of the node it is running on. While running through that nested loop to check if there is a an update needed we are also checking there is an frr config for an already deleted pod. This is ok unless there is at least one pod with a secondary IF, if not the cleanup won't happen, which is the case for the FRRConfiguration for the last deleted pod. This issue was only seen randomly because the functional test was not waiting for the pod and its FRRConfiguration to exist before it started the delete test. This change fixes the functional test and moves the cleanup out of the mentioned loop so it also gets checked properly when the last pod gets deleted. Signed-off-by: Martin Schuppert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/163374cbedcc480a8a04255da14ca84b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 36s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3ee459fefc6c4e0f8deda6e0d370de3d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 08s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6e466a3021f4734991caafeab482523 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 37s |
Same error here as [1]: Looks like we have a cross-repo Zuul Tempest problem. [1] openstack-k8s-operators/openstack-operator#1278 (comment) |
|
recheck |
openshift-merge-bot
bot
merged commit ae8379c
into
openstack-k8s-operators:main
Currently the process of processing the FRRConfigurations is:
While running through that nested loop to check if there is a an update needed we are also checking there is an frr config for an already deleted pod.
This is ok unless there is at least one pod with a secondary IF, if not the cleanup won't happen, which is the case for the FRRConfiguration for the last deleted pod.
This issue was only seen randomly because the functional test was not waiting for the pod and its FRRConfiguration to exist before it started the delete test.
This change fixes the functional test and moves the cleanup out of the mentioned loop so it also gets checked properly when the last pod gets deleted.