Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tripleo: split network config control flags #928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdando
Copy link
Contributor

@bogdando bogdando commented Oct 11, 2024

Add granular tripleo netconfig control flags

In local multi-cell setups, we use tripleo netconfig for cell stacks.
Extend it to the main stack as well.

In today multi-node CI we keep it disabled, so this
addition doesn't change the status quo.

Add a flag to managing tripleo default routes. This is
only used with tripleo dev setups, but may be extended to edpm dev
envs if needed.

Align the config download templates to use them consistently

Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/55229

@openshift-ci openshift-ci bot requested review from fao89 and viroel October 11, 2024 10:37
@bogdando
Copy link
Contributor Author

testing it here https://review.rdoproject.org/r/c/testproject/+/53212 for multi-cell

Will test it with existing multinode jobs later

@fao89
Copy link
Contributor

fao89 commented Oct 11, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bogdando, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a391d925847f42628945826865f25c77

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 11s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 20m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 07s

@bogdando bogdando force-pushed the ext_net_opt branch 3 times, most recently from 6b634f7 to 9300e3c Compare October 17, 2024 11:35
@bogdando

This comment was marked as outdated.

@bogdando
Copy link
Contributor Author

bogdando commented Oct 18, 2024

a multi-cell testproject [0] has deployed all cells stacks OK [1]

[0] https://review.rdoproject.org/r/c/testproject/+/53212
[1] https://logserver.rdoproject.org/12/53212/21/check/adoption-multinode-to-extracted-crc-no-ceph-novacells/2ae3a95/controller/ci-framework-data/logs/ci_script_010_run_tripleo.log


TASK [tripleo_cellv2 : debug] **************************************************
ok: [np0004953221] => {
    "cells.stdout_lines": [
        "+---------+--------------------------------------+----------------------------------------------------------------------+-------------------------------------------------------
-------------------------------------------------------------------+----------+",
        "|   Name  |                 UUID                 |                            Transport URL                             |                                                   Data
base Connection                                                    | Disabled |",
        "+---------+--------------------------------------+----------------------------------------------------------------------+-------------------------------------------------------
-------------------------------------------------------------------+----------+",
        "|  cell0  | 00000000-0000-0000-0000-000000000000 |                                none:/                                | mysql+pymysql://nova:****@172.17.0.130/nova_cell0?read
_default_file=/etc/my.cnf.d/tripleo.cnf&read_default_group=tripleo |  False   |",
        "|  cell1  | 7808e7b1-c9d9-4e20-a052-585382556152 | rabbit://guest:****@np0004953222.internalapi.localdomain:5672/?ssl=0 |    mysql+pymysql://nova:****@172.17.0.133/nova?read_de
fault_file=/etc/my.cnf.d/tripleo.cnf&read_default_group=tripleo    |  False   |",
        "|  cell2  | 3922096b-90d5-4b4d-a1d6-f4d3d6ba19b7 | rabbit://guest:****@np0004953227.internalapi.localdomain:5672/?ssl=0 |    mysql+pymysql://nova:****@172.17.0.136/nova?read_de
fault_file=/etc/my.cnf.d/tripleo.cnf&read_default_group=tripleo    |  False   |",
        "| default | 052729c0-e3bc-4ed3-a533-5a3043f02f4a | rabbit://guest:****@np0004953221.internalapi.localdomain:5672/?ssl=0 |    mysql+pymysql://nova:****@172.17.0.130/nova?read_de
fault_file=/etc/my.cnf.d/tripleo.cnf&read_default_group=tripleo    |  False   |",
        "+---------+--------------------------------------+----------------------------------------------------------------------+-------------------------------------------------------
-------------------------------------------------------------------+----------+"
    ]
}

still have to make the multi-node CI passing

@marios marios self-requested a review October 21, 2024 10:50
@bogdando bogdando force-pushed the ext_net_opt branch 3 times, most recently from a43f2a4 to 5c820b0 Compare October 25, 2024 11:32
devsetup/tripleo/ceph.sh Outdated Show resolved Hide resolved
devsetup/scripts/tripleo.sh Outdated Show resolved Hide resolved
@bogdando bogdando changed the title tripleo muilti-cell: conditionally use ext net tripleo muiltinode: conditionally configure network, attach ext net, and control undercloud default route Oct 28, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d496218e8e4047d4bf72ea29a211d81a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 32m 38s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 26m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 27s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 34m 38s
adoption-standalone-to-crc-no-ceph-provider FAILURE in 1h 41m 19s

Copy link

This change depends on a change that failed to merge.

Change https://review.rdoproject.org/r/c/rdo-jobs/+/55215 is needed.

devsetup/tripleo/ceph.sh Outdated Show resolved Hide resolved
@bogdando bogdando changed the title tripleo muiltinode: conditionally configure network, attach ext net, and control undercloud default route tripleo muiltinode: conditionally configure network, attach ext net, and control default routes Oct 31, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/07de8f9effcf4964a3b8dfe848273ffd

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 39s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 32m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 43s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 15m 49s
adoption-standalone-to-crc-no-ceph-provider RETRY_LIMIT in 15m 28s

@bogdando bogdando force-pushed the ext_net_opt branch 2 times, most recently from 8296226 to f7a954b Compare November 5, 2024 13:00
@bogdando
Copy link
Contributor Author

bogdando commented Nov 6, 2024

the testproject results look mostly OK now, just retriggering to get rid of intermittent errors

Copy link

This change depends on a change that failed to merge.

Change https://review.rdoproject.org/r/c/rdo-jobs/+/55229 is needed.

@bogdando bogdando changed the title tripleo muiltinode: conditionally configure network, attach ext net, and control default routes tripleo: split network config control flags Nov 6, 2024
Add granular tripleo netconfig control flags

In local multi-cell setups, we use tripleo netconfig for cell stacks.
Extend it to the main stack as well.

In today multi-node CI we keep it disabled, so this
addition doesn't change the status quo.

Add a flag to managing tripleo default routes. This is
only used with tripleo dev setups, but may be extended to edpm dev
envs if needed.

Align the config download templates to use them consistently

Signed-off-by: Bohdan Dobrelia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants