switch to structured logging #323
Conversation
|
Hi @pinikomarov. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
pinikomarov
force-pushed
the
structured_logging
branch
from
0258fb6 to
3bd4140
Compare
pinikomarov
force-pushed
the
structured_logging
branch
from
3bd4140 to
6919c00
Compare
|
/retest |
pinikomarov
force-pushed
the
structured_logging
branch
from
6919c00 to
df8512a
Compare
update logging implementation update loggingWq update logging update logging update logging update logging
pinikomarov
force-pushed
the
structured_logging
branch
from
df8512a to
8a9aff0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pinikomarov, steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit f314608
into
openstack-k8s-operators:main
This automatically adds additional fields like reconcile_id etc.. from the controller context.
before :
2023-05-18T01:53:14+03:00 INFO controllers.KeystoneAPI Reconciled Service init successfullyafter:
2023-10-19T11:33:31+03:00 INFO Controllers.IronicNeutronAgent Reconciled IronicNeutronAgent upgrade successfully {"controller": "ironicneutronagent", "controllerGroup": "ironic.openstack.org", "controllerKind": "IronicNeutronAgent", "IronicNeutronAgent": {"name":"ironic-neutron-agent-sample","namespace":"openstack"}, "namespace": "openstack", "name": "ironic-neutron-agent-sample", "reconcileID": "957c9fcc-9ebc-4dc7-a077-31b8b7f1e8c0"}*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.