-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert runlogwatch.sh to use inotifywait #484
Convert runlogwatch.sh to use inotifywait #484
Conversation
This has been moved to FR3, hold until FR1 is branched |
This can be reviewed now, fr1 has been branched |
/retest |
2 similar comments
/retest |
/retest |
Ironic images have been promoted |
/retest |
3c4aeab
to
efdef8d
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f34fd04e6fae4c0aa2c742b31ad2ccab ✔️ noop SUCCESS in 0s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5973127c561641fca6c1ae6e82301d40 ✔️ noop SUCCESS in 0s |
The kuttl failure looks unrelated, the ramdisk-logs.log looks correct[1]. I think this is ready for review @hjensas |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/412fb8c0bcb649dca1a6a03089d55b35 ✔️ noop SUCCESS in 0s |
This aligns with metal3 runlogwatch.sh[1] which is possible now that inotify-tools package is available[2]. [1] https://github.com/metal3-io/ironic-image/pull/548/files [2] openstack-k8s-operators/tcib@0795bb9 Jira: OSPRH-10240
@hjensas CI is green on this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjensas, steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
e49dd30
into
openstack-k8s-operators:main
This aligns with metal3 runlogwatch.sh[1] which is possible now that inotify-tools package is available[2].
[1] https://github.com/metal3-io/ironic-image/pull/548/files
[2] openstack-k8s-operators/tcib@0795bb9
Jira: OSPRH-10240