Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert runlogwatch.sh to use inotifywait #484

Merged

Conversation

steveb
Copy link
Collaborator

@steveb steveb commented Oct 15, 2024

This aligns with metal3 runlogwatch.sh[1] which is possible now that inotify-tools package is available[2].

[1] https://github.com/metal3-io/ironic-image/pull/548/files
[2] openstack-k8s-operators/tcib@0795bb9

Jira: OSPRH-10240

@steveb
Copy link
Collaborator Author

steveb commented Oct 16, 2024

This has been moved to FR3, hold until FR1 is branched

@steveb
Copy link
Collaborator Author

steveb commented Oct 22, 2024

This can be reviewed now, fr1 has been branched

@steveb
Copy link
Collaborator Author

steveb commented Oct 22, 2024

/retest

2 similar comments
@steveb
Copy link
Collaborator Author

steveb commented Oct 28, 2024

/retest

@steveb
Copy link
Collaborator Author

steveb commented Oct 31, 2024

/retest

@steveb
Copy link
Collaborator Author

steveb commented Nov 3, 2024

Ironic images have been promoted
/retest

@steveb
Copy link
Collaborator Author

steveb commented Nov 5, 2024

/retest

@steveb steveb force-pushed the inotifywait branch 2 times, most recently from 3c4aeab to efdef8d Compare November 6, 2024 22:13
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f34fd04e6fae4c0aa2c742b31ad2ccab

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 17m 41s
podified-multinode-ironic-deployment FAILURE in 1h 01m 57s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5973127c561641fca6c1ae6e82301d40

✔️ noop SUCCESS in 0s
✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 33s
podified-multinode-ironic-deployment FAILURE in 1h 04m 16s

@steveb
Copy link
Collaborator Author

steveb commented Nov 26, 2024

recheck
/retest
inotify-tools is now in quay.io/podified-antelope-centos9/openstack-ironic-inspector:current-podified

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/412fb8c0bcb649dca1a6a03089d55b35

✔️ noop SUCCESS in 0s
openstack-k8s-operators-content-provider FAILURE in 13m 28s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

This aligns with metal3 runlogwatch.sh[1] which is possible now that
inotify-tools package is available[2].

[1] https://github.com/metal3-io/ironic-image/pull/548/files
[2] openstack-k8s-operators/tcib@0795bb9

Jira: OSPRH-10240
@steveb
Copy link
Collaborator Author

steveb commented Nov 27, 2024

@hjensas CI is green on this now

Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@steveb
Copy link
Collaborator Author

steveb commented Nov 28, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit e49dd30 into openstack-k8s-operators:main Nov 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants