Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Fix ironic-python-agent - CA bundle inject #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Dec 19, 2024

The ironic-python-agent needs the internal-ca-bundle.pem.

Add a volume mount for the internal-ca-bundle.pem as well and update the pxe-init script to copy both certificates to the ramdisk image.

Turns out the above is wrong, I will update this once I have found the actual root case.

Jira: OSPRH-12526

@hjensas hjensas added bug Something isn't working do-not-merge/hold labels Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Dec 20, 2024

do we need this? our big ca bundle already has the internal-ca-bundle included.

@hjensas
Copy link
Contributor Author

hjensas commented Dec 20, 2024

do we need this? our big ca bundle already has the internal-ca-bundle included.

Thanks Martin!
It is possible my root cause analysis is wrong.

We are injecting that (or atleast we intend to) since: #491

also after looking more at the lib-common, I think this patch would actually just mount the big ca bundle again under a different name. Anyhow ... I'll go back to figuring out the root cause.

@hjensas hjensas changed the title Fix ironic-python-agent - CA bundle inject [DNM] Fix ironic-python-agent - CA bundle inject Dec 20, 2024
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@hjensas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ironic-operator-build-deploy-kuttl afd5a32 link true /test ironic-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants