Use internal Volume struct for tls #578
Closed
+28
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems good to me |
bshephar
force-pushed
the
tls-internal-storage-struct
branch
from
21c6972 to
bd2119d
Compare
This change switches the tls package over to using the lib-common copy of the Volume struct. This will allow us to append TLS volumes to the volume struct in each service Operator as we update the version of lib-common in each of them. Signed-off-by: Brendan Shephard <[email protected]>
|
I am not sure I understand the intend for this switch. the tls volumes are appended to the deployment volumes in the operators, so doesn't this change just required another conversion to the k8s volume? |
|
-1 to switch to |
|
Yeah, my bad. This isnt' necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches the tls package over to using the lib-common copy of the Volume struct. This will allow us to append TLS volumes to the volume struct in each service Operator as we update the version of lib-common in each of them.