Create getDNSClusterDomain #580
Merged
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averdagu
added a commit
to averdagu/ovn-operator
that referenced
this pull request
Nov 12, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
|
LGTM |
stuggi
reviewed
Nov 13, 2024
| package clusterdns | ||
|
|
||
| // GetDNSClusterDomain - Return openshift dns Cluster Domain name | ||
| func GetDNSClusterDomain() (string, error) { |
There was a problem hiding this comment.
should we keep returning an error ? I guess when there is the way to check if from the cluster we also have to change the parameters which get passed into the func
There was a problem hiding this comment.
Hmmm, I guess we should return error (in order to not need to modify all operators using this function) when we modify logic and try to get value from cluster.
And I don't think we ever need to use any parameter, as openshift dns operator only accepts one object in the cluster, so there's no need to parameterizice it. [0]
I just realize that I return "value, error" but is it possible that the convention we're using is "error, value"?
There was a problem hiding this comment.
but how would you query the dns object from the cluster? we'd need to either pass in that object, or pass in a client to be able to get it
There was a problem hiding this comment.
Oh true. So since if this code changes we'll need to update the operators you suggest to remove the error returned?
There was a problem hiding this comment.
since we have to change it anyways, yes lets remove it
averdagu
added a commit
to averdagu/ovn-operator
that referenced
this pull request
Nov 13, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/ovn-operator
that referenced
this pull request
Nov 13, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
Openshift DNS creates it's records using the value in clusterDomain. This information could be customizable in the futre. Currently on most of the operators they're using a hardcoded value, this function allows to all operators get this information from lib-common, and in case in the future this value is customizable we'd only need to change it here.
averdagu
force-pushed
the
retrieve-core-dns-domain
branch
from
0abe832 to
81476aa
Compare
averdagu
added a commit
to averdagu/ovn-operator
that referenced
this pull request
Nov 18, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/ovn-operator
that referenced
this pull request
Nov 18, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/openstack-operator
that referenced
this pull request
Dec 2, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/openstack-operator
that referenced
this pull request
Dec 2, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/openstack-operator
that referenced
this pull request
Dec 2, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580 Resolves: OSPRH-3627
averdagu
added a commit
to averdagu/infra-operator
that referenced
this pull request
Dec 2, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/telemetry-operator
that referenced
this pull request
Dec 2, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/openstack-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580 Resolves: OSPRH-3627
averdagu
added a commit
to averdagu/openstack-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580 Resolves: OSPRH-3627
averdagu
added a commit
to averdagu/infra-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/infra-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/telemetry-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/openstack-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580 Resolves: OSPRH-3627
averdagu
added a commit
to averdagu/telemetry-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/telemetry-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/openstack-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Depends-on: openstack-k8s-operators/lib-common#580 Resolves: OSPRH-3627
averdagu
added a commit
to averdagu/infra-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/infra-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/infra-operator
that referenced
this pull request
Dec 10, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
averdagu
added a commit
to averdagu/ovn-operator
that referenced
this pull request
Dec 16, 2024
Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators. Resolves: OSPRH-3627 Depends-on: openstack-k8s-operators/lib-common#580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openshift DNS creates it's records using the value in clusterDomain. This information could be customizable in the futre.
Currently on most of the operators they're using a hardcoded value, this function allows to all operators get this information from lib-common, and in case in the future this value is customizable we'd only need to change it here.
Related-Issue: OSPRH-3627