[conditions] Reset conditions on Init() #590
Merged
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the operators changed to use CreateServiceReadyCondition instead of ExposeServiceReadyCondition. An update of an existing environment would result in the ExposeServiceReadyCondition to be never removed from the conditions list of a CR because the list is not reset on Init(). This adds a Reset() method and a call right at the start of Init(). Signed-off-by: Martin Schuppert <[email protected]>
|
in minor update from FR1 to main e.g. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/59699/rehearse-59699-pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl/1867609784287498240 the old exposeservice condition in novaapi was reset to unknown (not yet sure why) and never set to true again (expected). as a result the minor update got stuck. |
1 task
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Dec 17, 2024
When the dataplane minor update finished, the controller will not set a OpenStackVersionMinorUpdateOVNDataplane after [1]. This change will remove the no longer required check. [1] openstack-k8s-operators/lib-common#590 Signed-off-by: Martin Schuppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the operators changed to use CreateServiceReadyCondition instead of ExposeServiceReadyCondition. An update of an existing environment would result in the ExposeServiceReadyCondition to be never removed from the conditions list of a CR because the list is not reset on Init().
This adds a Reset() method and a call right at the start of Init().
Related: https://issues.redhat.com//browse/OSPRH-4164