Add TopoRef struct and common functions #594
Merged
+374
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
force-pushed
the
topologyref
branch
2 times, most recently
from
00e666b to
27cca91
Compare
fmount
commented
Jan 21, 2025
fmount
force-pushed
the
topologyref
branch
2 times, most recently
from
5618886 to
f3ec112
Compare
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 21, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
stuggi
reviewed
Jan 21, 2025
fmount
force-pushed
the
topologyref
branch
2 times, most recently
from
8cbe0a8 to
2005db7
Compare
stuggi
reviewed
Jan 22, 2025
olliewalsh
pushed a commit
to olliewalsh/glance-operator
that referenced
this pull request
Jan 22, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 22, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 22, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 23, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
commented
Jan 23, 2025
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 23, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
ASBishop
reviewed
Jan 23, 2025
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 24, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
changed the title
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 24, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
topologyref
branch
3 times, most recently
from
297cfdc to
13607ec
Compare
TopoRef represents a struct referenced by the service operators to retrieve a Topology that is eventually applied to the resulting Deployments/StatefulSets. This patch allows to reduce the amount of code duplication across the operators, providing both the TopoRef struct that can be added in the Services' API, as well as "EnsureTopologyRef" and "EnsureDeletedTopologyRef" where the basic logic of retrieving and managing finalizers is implemented. Signed-off-by: Francesco Pantano <[email protected]>
|
@olliewalsh @stuggi this change is ready, and as you can see I cleaned up the implementation for glance that consumes this patch [1]. |
ASBishop
reviewed
Jan 27, 2025
|
|
||
| // no Topology is passed at all or some data is missing | ||
| if topologyRef == nil || (topologyRef.Name == "" || topologyRef.Namespace == "") { | ||
| return ctrl.Result{}, nil |
There was a problem hiding this comment.
This is treated as an error on L43, but I agree it's OK to "quietly succeed" here and not return an error.
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 28, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 28, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 28, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 29, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
fmount
added a commit
to fmount/glance-operator
that referenced
this pull request
Jan 29, 2025
…mmon This patch updates the glance-operator to consume a TopologyRef struct and the related functions from lib-common [1]. This allows to avoid code duplication while spreading the pattern across the board. [1] openstack-k8s-operators/lib-common#594 Signed-off-by: Francesco Pantano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopologyRefrepresents a struct referenced by the service operators to retrieve aTopologyCR that is eventually processed and applied to the resultingDeployments/StatefulSets.This patch allows to reduce the amount of code duplication across the operators, providing both
TopologyRefstruct that can be added in the Services' API, as well asEnsureTopologyRefandEnsureDeletedTopologyRefwhere the basic logic of retrieving and managingfinalizersis implemented.